qt: should we keep custom navigation?
When NavigationAttached
was introduced (!327 (merged)) the usage of Qt Quick Controls was limited. Most of the stuff was directly item based.
There were a lot of problems with key navigation because it required using FocusScope
everywhere.
Now that we follow a more conventional approach, such that we use Qt Quick Controls, and it automatically sets focus scoping behavior based on the control type (https://doc.qt.io/qt-6/qtquickcontrols-focus.html), I wonder if it is good idea to keep using it.
-
NavigationAttached
can not be integrated properly without private header access. I tried this other ways myself, but it did not go anywhere. There are limitations. - Key actions should not be part of navigation. Besides, we can use
Keys
for that instead.
This MR aims to refactor NavigableFocusScope in order to make it usable without the need to inherit from it
This is no longer valid that we do not need to use focus scopes everywhere because of Qt Quick Controls. I do not see any reason to keep this class.
Now that the application has grown and become more mature with Qt Quick Controls, I would rather remove this class and use KeyNavigation
instead.
Ping @chub, @jagannatharjun, @bunjee.