Spacebar toggles control last clicked on instead of play/pause

changed milestone to %Qt redesign (VLC 4.0)

assigned to @chub

Could you describe the steps you are taking for this ?

assigned to @bunjee and unassigned @chub

I play a video or audio file

click another control like volume toggle or back 10s

then press space and it will do that action that was clicked

yes, this is an issue, keyboard actions on widgets that have the active focus but not the visual focus should be inhibited (and sent to the vout in the case of the player).

After investigating with @chub, when clicking a Control it gets focused by default and the spacebar behavior is hard-coded in its implementation. As a result, the following is never called in Player.qml: mainInterface.sendHotkey.

At the moment, we are not exactly sure how to prevent the Control to do that without breaking keyboard navigation.

I'm open to suggestions on that matter.

cc @jagannatharjun @fuzun

You can add this to InterfaceWindowHandler::eventFilter

    case QEvent::KeyRelease:
    case QEvent::KeyPress:
    {
        const auto keyEvent = static_cast<QKeyEvent*>(event);

        // Navigation keys should not be filtered
        // otherwise navigation will not work, or
        // we need to define a global navigation mode
        // to enter explicitly
        switch (keyEvent->key()) {
        case Qt::Key_Left:
        case Qt::Key_Right:
        case Qt::Key_Up:
        case Qt::Key_Down:
        case Qt::Key_Tab:
        case Qt::Key_Backtab:
            return false;
        }

        const auto focusObject = m_window->focusObject();
        const bool isControl = focusObject->inherits("QQuickControl");

        if (isControl)
        {
            const QVariant hasVisualFocus = QQmlProperty(focusObject,
                                                         "visualFocus",
                                                         qmlContext(focusObject)).read();
            assert(hasVisualFocus.canConvert<bool>());

            if (hasVisualFocus.value<bool>())
            {
                // Control has visual focus, let it handle the key
                return false;
            }
        }
        else
        {
            // We don't want to break key handling
            // in other items.
            return false;
        }

        if (event->type() == QEvent::KeyPress)
            m_mainInterface->sendHotkey(static_cast<Qt::Key>(keyEvent->key()), keyEvent->modifiers());

        keyEvent->accept();

        return true;
    }

the idea might work, I don't know though if the filtering should be done globally like you propose or at the QML component level

const auto focusObject = m_window->focusObject();

I'm not sure this works with every compositor, I think it's best to use activeFocusItem, this of course need to be forwarded from every compositor

switch (keyEvent->key()) {
        case Qt::Key_Left:
        case Qt::Key_Right:
        case Qt::Key_Up:
        case Qt::Key_Down:
        case Qt::Key_Tab:
        case Qt::Key_Backtab:
            return false;
        }

we probably need a better policy than that, assume this scenario, if you're in the player and you press up the volume will goes up, but the visual focus is also be gained.

Thanks a bunch @fuzun, that's a really good start.

With this implementation it seems focusObject() always returns QMainWindow.

How do I access the QQuickWindow from InterfaceWindowHandler ?

How do I access the QQuickWindow from InterfaceWindowHandler

you don't

As I said in my previous message, and told you privately, this of course need to be forwarded from every compositor

in other words, every Compositor has a QQuickWindow in its implementation, this need to be exposed or provide an activeFocusItem function that will forward the call to the actual QQuickWindow

mentioned in merge request !924 (merged)

closed with commit 76eccbfb

closed with merge request !924 (merged)

changed milestone to %4.0

Spacebar toggles control last clicked on instead of play/pause

Child items 0

Activity