Video doesn't scale until manual resize (libVLC macOS)

added Component::Video: macOS / iOS / tvOS / visionOS label

small test video

Added attachment:

drop.avi

I can also see the issues on the QtPlayer built with Qt5.15.2 on macOS 10.15.7; VLC 3.0.11.1.

I've already attached a small video which I use in testing. Another can be found here: https://drive.google.com/file/d/1k5sScUBescxGHeZG5AKmpOyK9f_ZjLzt/view?usp=sharing

Does it work on other OSes?

Yes.

added Platform::macOS label

mentioned in issue VLCKit#486 (closed)

mentioned in issue VLCKit#464 (closed)

Please resize the video manually. I had tried with these codes and it is working well now.

var fixedFirstTimeInvalidSize = false

 func fixFirstTimeInvalidSize(view: NSView) {
     DispatchQueue.main.asyncAfter(deadline: .now() + 0.005) {
        if self.fixedFirstTimeInvalidSize {
            return
        }
        if !self.vlcPlayer.hasVideoOut {
            self.fixFirstTimeInvalidSize(view: view) // delay
            return
        }
        if !self.fixedFirstTimeInvalidSize, let frame = view.window?.frame {
            view.setFrameSize(NSSize(width: frame.width+1, height: frame.height))
            self.fixedFirstTimeInvalidSize = true
            // revert back
            DispatchQueue.main.asyncAfter(deadline: .now() + 1) {
                view.setFrameSize(NSSize(width: frame.width-1, height: frame.height))
            }
        }
     }
  }

Not sure it's okay for me to mention here an issue with initial sizing of RTSP streams not solved by the workaround code above, since I just posted details in VLCKit#486 (closed)... so I just leave this quick link to that :)

assigned to @ePirat

assigned to @alexandre-janniaux and unassigned @ePirat

mentioned in merge request !1820 (merged)

changed milestone to %4.0

mentioned in merge request !1871 (merged)

changed milestone to %3.0.18

I think !1820 (merged) and !1871 (merged) are fixing the issue but I don't remember if I checked.

I might be wrong, be I think I checked a couple of months back and the fix was present in 4.0, but not in 3.x; it might have been merged later, though. In all cases, I want to thank you all SO VERY MUCH in advance if you're able to fix this in 3.0.18, because this is really killing me. Thank you, reallY!

Can you check if it's fixed with the nightly version?

@alexandre-janniaux Happy to try, thank you for your time. The only thing is, and this is getting embarrassing to admit , I honestly have no clue on how to compile VLCKit while pointing it to the nightly build of VLC. By any chance, VLCKit 3.0.18rc from a couple weeks ago would already include the fix?

I've re-triggered the CI at https://code.videolan.org/videolan/VLCKit/-/jobs/1137450, you should be able to download the artifact once it completes.

(Note that it doesn't include all the fixes on the video output for macos currently, but it includes the fix for this issue).

@alexandre-janniaux Thank you so much for all your help! I'm happy to report that replacing a previously compiled VLCKit framework with the artifacts you kindly provided today solves the issue of the video size being wrong at launch. A quick video comparing the behavior of the two frameworks in my app (sorry for the delay the RTSP cameras have to start displaying something):

comparison

I cannot express how grateful I am, I've been stuck on this for a long time, and I really look forward to be able to use these fixes in an upcoming VLCKit release. Thank you again!

Thanks for testing and sharing! You're welcome!

@alexandre-janniaux I hope I won't "overstay my welcome" if I ask you one last question.

In my app, I provide keyboard shortcuts and trackpad gestures to resize the window containing the video player. I do so by mapping the key combinations to NSWindow.setFrame(_ frameRect: NSRect, display displayFlag: Bool, animate animateFlag: Bool), and to keep things "fast" I set the animateFlag parameter to false.

Now, I'm noticing that calling that method with animateFlag = false while linking to the new framework you kindly made available yesterday doesn't seem to trigger the resizing of the view, which instead happened automatically with previous versions of VLCKit. If I set animateFlag = true, the videoView automatically resizes to the new window dimensions even with the artifacts from yesterday. I thought I'd provide a quick video showing the different behavior, in case my explanation isn't very clear:

resizing-behavior-with-setframe-animate-disabled

By all means, switching to animate window resizing won't be a deal breaker, but since I understand you've worked on many (or all) of the underlying fixes to the resizing issue, I thought I'd ask if I'm missing something that could invoke the auto-resizing of the videoView even without animating window size changes.

Please, feel free to ignore my question if you don't have time or if it's out of scope for the forum, and again thank you for your work!

Do you have a complete snippet of code somewhere that I can use to check and reproduce the issue ?

Hi and thank you @alexandre-janniaux, I very much appreciate you taking the time to investigate my issue.

I tried to extract the relevant code from my app, hopefully what follows will be helpful to reproduce the issue and won't take you too much time to setup.

First, I set my app's main window, the one containing the videoView, to a NSWindow subclass with a couple helper methods for handling the resizing (basically, I'm wrapping NSWindow.setFrame(_ frameRect: NSRect, display displayFlag: Bool, animate animateFlag: Bool) with some niceties):

import Cocoa

// A few preset values for resizing
enum WindowPresetSize : CGFloat {
    
    case small = 8
    case regular = 4
    case large = 2
}


class Window: NSWindow {
    
    func resizeToPreset(presetSize : WindowPresetSize, animate : Bool) {
        
        if let visibleScreenFrame = NSScreen.main?.visibleFrame,
           let windowContentView = contentView {
            
            let videoPlayerWidth = windowContentView.frame.width
            let videoPlayerHeight = windowContentView.frame.height
            let aspectRatio = videoPlayerWidth / videoPlayerHeight
            
            var newSize = CGSize()
            let width = min((visibleScreenFrame.height * aspectRatio) / presetSize.rawValue, visibleScreenFrame.width / presetSize.rawValue)
            newSize = CGSize(width: width, height: visibleScreenFrame.height / presetSize.rawValue)
            
            resizeWindow(newSize: newSize, animate: animate)
        }
    }
    
    
    fileprivate func resizeWindow(newSize : NSSize, animate : Bool) {
        
        var newFrame = self.frame
        
        // Prevent window from moving during the resize process
        newFrame.origin.y += newFrame.size.height
        newFrame.origin.y -= newSize.height
        
        newFrame.size = newSize
        
        self.setFrame(newFrame, display: true, animate: animate)
    }
}

Then, in my NSViewController subclass, I hook up a few calls to the resizing method above, in order to test the different scenarios (with animation, when it properly resizes automatically the video to fit the window, and without animation, where I'm seeing the issue of the video not scaling down):

class ViewController: NSViewController {
    //...

    // Working as expected:

    @IBAction func makeSmallAnimating(_ sender: Any) {

        (self.videoView.window as? Window)?.resizeToPreset(presetSize: .small, animate: true)
    }

    @IBAction func makeRegularAnimating(_ sender: Any) {

        (self.videoView.window as? Window)?.resizeToPreset(presetSize: .regular, animate: true)
    }


    // Window resizes, but the video doesn't scale:

    @IBAction func makeSmallWithoutAnimation(_ sender: Any) {

        (self.videoView.window as? Window)?.resizeToPreset(presetSize: .small, animate: false)
    }

    @IBAction func makeRegularWithoutAnimation(_ sender: Any) {

        (self.videoView.window as? Window)?.resizeToPreset(presetSize: .regular, animate: false)
    }

    // ...
}

I hope this will allow you to test what I'm reporting without spending too much time on it. Did I say thank you? Thank you!

Finally, sorry if I didn't provide you a stand-alone functioning example; actually, I could if you need me to, but I'll probably need a couple days to set things up in a new focused example app.

@alexandre-janniaux I am not sure why, but compiling and embedding today's VLCKit-3.4.1b12 seems to have fixed the issue I reported yesterday: with this version, the media size is always correct at launch, same as with your fix from a few days ago, but resizing the window without animating the change also is properly fitting the video to new window size. Both if it's something you've done or not, thank you so much for your help!

closed

added Status::fixed label

mentioned in merge request !4031 (merged)

Video doesn't scale until manual resize (libVLC macOS)

Child items 0

Activity