‘const struct pl_color_map_params’ has no member named ‘tone_mapping_desaturate’

Compile error of

• release version 3.0.7.1
• Compile OS is Manjaro GNU+Linux. glibc 2.29

Forum thread https://forum.videolan.org/viewtopic.php?f=12&t=150307&p=494217

  CC       video_output/opengl/libgl_plugin_la-display.lo
In file included from video_output/opengl/display.c:31:
video_output/opengl/display.c: In function ‘vlc_entry__3_0_0f’:
video_output/opengl/vout_helper.h:189:65: error: ‘const struct pl_color_map_params’ has no member named ‘tone_mapping_desaturate’; did you mean ‘tone_mapping_param’?
  189 |     add_float("tone-mapping-desat", pl_color_map_default_params.tone_mapping_desaturate, \
      |                                                                 ^~~~~~~~~~~~~~~~~~~~~~~
../include/vlc_plugin.h:246:54: note: in definition of macro ‘vlc_config_set’
  246 | #define vlc_config_set(...) vlc_set (opaque, config, __VA_ARGS__)
      |                                                      ^~~~~~~~~~~
video_output/opengl/vout_helper.h:189:5: note: in expansion of macro ‘add_float’
  189 |     add_float("tone-mapping-desat", pl_color_map_default_params.tone_mapping_desaturate, \
      |     ^~~~~~~~~
video_output/opengl/vout_helper.h:205:5: note: in expansion of macro ‘add_glopts_placebo’
  205 |     add_glopts_placebo ()
      |     ^~~~~~~~~~~~~~~~~~
video_output/opengl/display.c:71:5: note: in expansion of macro ‘add_glopts’
   71 |     add_glopts ()
      |     ^~~~~~~~~~

Because this is a release and blocking further debugging, I gave it a high priority.

I have now pulled and compiled the Git head and it compiled without this error. I would close it but see no way.

Thanks for the report and also the follow-up!

assigned to @Courmisch

added Component::Build system Platform::GNU/Linux Status::works for me labels

changed milestone to %3.0.x maintenance

closed

ok that's because /usr/include/libplacebo/shaders/colorspace.h got updated (long ago)!

my current: local/libplacebo 1.18.0-2 (Reusable library for GPU-accelerated video/image rendering primitives)

I was trying to (re)compile 'git+https://github.com/videolan/vlc.git#commit=db9131787a' which is the last known(to me) vlc version to use only 1 window.

I'll try latest vlc git(maybe it uses 1 window by now? instead of two - nope, still two in commit ae84c42b Sep 22 18:03:26), but it already gave me a compilation error(irrelevant to this issue though).

mentioned in issue #22684 (closed)

changed milestone to %3.0.9