Skip to content
Snippets Groups Projects

webvtt: align:start/end seem inverted

    • Closed Issue created by dlecorvlc @dlecorvlc

    Tested on VLC 3.0.6 on Windows: when using a french WebVTT subtitle where I add a "align:start" at the end of a cue, the subtitle gets aligned to the right (and "align:end" aligns to the left), while "align:left" correctly aligns to the left.

    I think that in that case "align:start" should align to the left.

    I think the problem is in modules/codec/webvtt/subsvtt.c:GetCueTextAlignment

        case WEBVTT_ALIGN_START:
        return ((p_cue->settings.vertical == WEBVTT_ALIGN_RIGHT) ?
                 SUBPICTURE_ALIGN_LEFT : SUBPICTURE_ALIGN_RIGHT);
    case WEBVTT_ALIGN_END:
        return ((p_cue->settings.vertical == WEBVTT_ALIGN_RIGHT)) ?

    SUBPICTURE_ALIGN_RIGHT : SUBPICTURE_ALIGN_LEFT;

    While by default, for horizontal text, settings.vertical == WEBVTT_ALIGN_AUTO

    (disclaimer: it's my first dive in VLC sources, I may be very wrong)

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    Please register or sign in to reply

    VideoLAN code repository instance