O_TMPFILE is kernel >= 3.11 only

breaks non DRI decoding on platforms not providing MEMFD_CREATE

int vlc_memfd(void)
{
#ifdef HAVE_MEMFD_CREATE
    int fd = memfd_create(PACKAGE_NAME"-memfd",
                          MFD_CLOEXEC | MFD_ALLOW_SEALING);
    if (fd != -1 || errno != ENOSYS)
        return fd;
#endif
    return open("/tmp", O_RDWR | O_CLOEXEC | O_TMPFILE, S_IRUSR | S_IWUSR);
}

added Component::Core Platform::GNU/Linux Severity::normal Type::bug Version::master git labels

changed milestone to %Bugs paradize

changed the description

ex: Centos provides only 3.10

https://en.wikipedia.org/wiki/CentOS#Latest_version_information

Linux 3.10 is EOL for 18 months. Complain to CentOS.

added Status::not VLC label

closed

Replying to [comment:3 Rémi Denis-Courmont]:

Linux 3.10 is EOL for 18 months. Complain to CentOS.

Ignoring part of the market distro to create time consuming silent bugs.

Especially when just moving the #ifdef around the whole code makes fallback possible.(HAVE_MEMFD_CREATE >= 3.18)

Replying to [comment:4 Francois Cartegnie]:

moving the #ifdef around the whole code makes fallback possible.(HAVE_MEMFD_CREATE >= 3.18)

The function already fails safe if O_TMPFILE is not supported. Unless the system is so broken that the user has write permission to / and /tmp does not already exist as a directory.

I don't think you it's nice to close this ticket. Francois created it and is a developer, he can closes it by himself if you give valid points.

This issue is interesting and open some interesting questions. Are we enforcing a minimum Linux version ? If so, TMPFILE on 3.11 seems quite unpredicable, cf. https://lwn.net/Articles/562294/

Personally, I would prefer to fallback to the posix implementation if HAVE_MEMFD_CREATE (3.18) is not defined.

Re-opened, cf. pending patch on the ML: https://mailman.videolan.org/pipermail/vlc-devel/2019-May/124264.html

removed Status::not VLC label

reopened

assigned to @tguillem and unassigned @MigrationBot

fixed by 3f5661b9444ff1f6287ae4b22b2c48d46a7a2b94

added Status::fixed label

closed