Skip to content
Snippets Groups Projects

MIDI demuxer fails to process some odd MIDI files

    • Closed Issue created by Wohlstand @Wohlstand

    Hello! Recently I have got some weird MIDI files are playing fine in some players (as an example, my), but won't be played in VLC and won't be opened in MIDI Editors: https://github.com/Wohlstand/libADLMIDI/issues/38#issuecomment-458643417

    [000055e88bb12790] dummy interface: using the dummy interface module...
[00007f0304c17720] smf demux: Track name:
[00007f0304c17720] smf demux: Copyright :
[00007f0304c17720] smf demux error: fatal parsing error
00007f0304c17720] smf demux: Track name:
[00007f0304c17720] smf demux: Copyright :
[00007f0304c17720] smf demux error: fatal parsing error

    The reason for this has been explained here:

    The reason for failure: the meta-event Key-Signature needs 2 bytes of payload, these files have 0.

    For VLC, it should be requested to implement permissive parsing to bypass such an error. There are just too numerous MIDI files floating around which don't conform. Sekaiju needs to implement rigorous bounds checking.

    Tested on multiple VLC versions. On my end is VLC 3.0.4

    Edited
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    Please register or sign in to reply

    VideoLAN code repository instance