MPEG TS with pids > 0x19ff broken between 3.0.2 and 3.0.3

assigned to @fcartegnie

Looks like your stream is broken.

added Component::Demuxers: TS label

changed milestone to %3.0.x maintenance

See #20284 (closed)

That can only trigger with HDMV registration which is bluray, and using the proper PID in that case is mandatory.

Where does that streams comes from ?

Replying to [comment:4 Francois Cartegnie]:

That can only trigger with HDMV registration which is bluray

There is nor HDMV registration. Attaching a patch that fixes this here, probably without changing the logic that you tried to put for #20284 (closed)

Where does that streams comes from ?

The streams come from an encoder + AppearTV MUX, they work fine with all sorts of other equipment and have been working fine for a while. There is no bluray involved anywhere in the process so the identification as bluray is probably dodgy somewhere.

Possible fix

Added attachment:

vlc-pid.patch

The fix doesn't change anything for bluray.

Does the recorder use registration HDPR instead of HDMV ?

I tried to follow up on why the code even gets to registration_type == TS_PMT_REGISTRATION_BLURAY and much to my dismay when building 3.0.3 now on rawhide as opposed to 2 weeks days ago - it doesn't.

My only explanation is that the then-gcc-8.1.1-1 was miscompiling something compared to the now-gcc-8.1.1-2 in rawhide

Sorry for the noise and I'll revisit if that turns out not to be the case.

After a bit more investigation let me revise the last comment. The gcc thing is not a thing, I was testing the wrong stream.

The stream that has the problem has a HDMV registration descriptor. I haven't noticed before because it never seemed to be a problem. Here is the PMT dump by wireshark.

MPEG2 Program Map Table
    Table ID: Program Map Table (PMT) (0x02)
    1... .... .... .... = Syntax indicator: 1
    .011 .... .... .... = Reserved: 0x3
    .... 0000 0010 0110 = Length: 38
    Program Number: 0x00da
    11.. .... = Reserved: 0x3
    ..00 011. = Version Number: 0x03
    .... ...1 = Current/Next Indicator: Currently applicable (0x1)
    Section Number: 0
    Last Section Number: 0
    111. .... .... .... = Reserved: 0x7
    ...1 1011 0011 1000 = PCR PID: 0x1b38
    1111 .... .... .... = Reserved: 0xf
    .... 0000 0000 1100 = Program Info Length: 0x00c
    Descriptor Tag=0x05
        Descriptor Tag: Registration Descriptor (0x05)
        Descriptor Length: 4
        Format identifier: 0x48444d56
    Descriptor Tag=0x88
        Descriptor Tag: Unknown (0x88)
        Descriptor Length: 4
        Descriptor Data: 0ffffcfc
    Stream PID=0x1b38
        Stream type: AVC video stream as defined in ITU-T Rec. H.264 | ISO/IEC 14496-10 Video (0x1b)
        111. .... .... .... = Reserved: 0x7
        ...1 1011 0011 1000 = Elementary PID: 0x1b38
        1111 .... .... .... = Reserved: 0xf
        .... 0000 0000 0011 = ES Info Length: 0x003
        Descriptor Tag=0x02
            Descriptor Tag: Video Stream Descriptor (0x02)
            Descriptor Length: 1
            0... .... = Multiple Frame Rate Flag: Single frame rate present (0)
            .001 1... = Frame Rate Code: 0x3
            .... .0.. = MPEG1 Only Flag: 0
            .... ..1. = Constrained Parameter Flag: 1
            .... ...0 = Still Picture Flag: 0
            Profile and Level Indication: 3
            Chroma Format: 0xfb
            ..1. .... = Frame Rate Extension Flag: 1
            ...1 1011 = Reserved: 0x1b
    Stream PID=0x1b48
        Stream type: ISO/IEC 11172 Audio (0x03)
        111. .... .... .... = Reserved: 0x7
        ...1 1011 0100 1000 = Elementary PID: 0x1b48
        1111 .... .... .... = Reserved: 0xf
        .... 0000 0000 0000 = ES Info Length: 0x000
    CRC 32: 0x80b575d8 [unverified]

I'll don't know if that's by spec or not. What gives ?

Outside of the little spec we know https://ffmpeg.org/pipermail/ffmpeg-devel/2010-July/088844.html


diff --git a/modules/demux/mpeg/ts_psi.c b/modules/demux/mpeg/ts_psi.c
index 7fe2b09d95..900db8947b 100644
--- a/modules/demux/mpeg/ts_psi.c
+++ b/modules/demux/mpeg/ts_psi.c
@@ -1620,7 +1620,8 @@ static void FillPESFromDvbpsiES( demux_t *p_demux,
         {
             p_pes->p_es->fmt.i_priority = ES_PRIORITY_NOT_DEFAULTABLE;
         }
-        else if( p_dvbpsies->i_pid > 0x19ff )
+        else if( (p_dvbpsies->i_pid >= 0x1a00 && p_dvbpsies->i_pid <= 0x1a1f) &&
+                 (p_dvbpsies->i_pid >= 0x1b00 && p_dvbpsies->i_pid <= 0x1b1f) )
         {
             /* We might just want to prio, but it will trigger multiple videos es */
             p_pes->p_es->fmt.i_priority = ES_PRIORITY_NOT_DEFAULTABLE;
-- 
2.14.4

Thanks for the patch, it obviously makes this particular buggy stream work.

You'll notice however that while the program as a whole has a HDMV registration descriptor (which is the reason its taken to be bluray) the individual video and audio pes-es do not have a registration descriptors at all. This in contrast to the stream in #20284 (closed) where each individual audio/video pes-es have it.

Perhaps the strict pid checks for second audio/video should be skipped for pids where there is no individual descriptor.

registration on PMT means global registration

added Status::fixed label

closed

in 3.0.4 too?

46139983

bp as

db3dd8dc

changed milestone to %3.0.7

changed milestone to %3.0.5

MPEG TS with pids > 0x19ff broken between 3.0.2 and 3.0.3

Child items 0

Activity