Crash on every aspect ratio change

more details?

tested on Tagged 0.9.0, change AR worked just fine

Hard to debug this on Win... Anyway, looks like vout_Destroy / vout_Create causes some pointers become uninitialized, thus randomly causing crash.

If it survives on onother OS, VLC at least complains about invalid picture status 6 or invalid refcount -1 which means the pointers are not pointing to the proper part of memory, or this memory was corrupted in between.

In fact, the real problem is that vout is being destroyed when MPEG stream changes aspect ratio.

When AR change is made by user, vout is not destroyed, and all work is done via AspectCallback() - see src/video_output/vout_intf.c

The same needs to happen when MPEG stream changes AR. But currently, the video output is destroyed here (src/video_output/video_output.c):

        if( ( p_vout->fmt_render.i_width != p_fmt->i_width ) ||
            ( p_vout->fmt_render.i_height != p_fmt->i_height ) ||
            ( p_vout->fmt_render.i_chroma != p_fmt->i_chroma ) ||
            ( p_vout->fmt_render.i_aspect != p_fmt->i_aspect ) ||
            p_vout->b_filter_change )
        {
            /* We are not interested in this format, close this vout */
            vlc_object_detach( p_vout );
            vlc_object_release( p_vout );
            vout_Destroy( p_vout );
            p_vout = NULL;
        }

changed the description

Ping. Does it work correctly with --codec ffmpeg?

Using --codec=ffmpeg works just by coincidence better, as ffmpeg seems to screw timing on my test stream after AR change and VLC decides to drop the pictures immediately following the change as late pictures.

But the main problem described here applies the same way - vout shouldn't be destroyed and again re-created after AR change. This would need some more time to implement, so I believe using libmpeg2-0.4.1 will be the easiest "fix" for 0.9.2, while this ticket need to remain open until a real fix is developed.

Fixed.

changed milestone to %0.9.2

added Status::fixed label

closed

Crash on every aspect ratio change

Child items 0

Activity