videotoolbox deinterlacing does not work on latest gen Macbook Pro + macOS Sierra
Firstly this commit looks suspect:
https://github.com/videolan/vlc/commit/6c61c7e1718afe9588336b659558f41f0eec7c6e
Specifically these lines:
- p_sys->b_enable_temporal_processing = status == noErr &&
-
CFDictionaryContainsKey(supportedProps,
-
kVTDecompressionProperty_DeinterlaceMode_Temporal);
I believe if it using CFDictionaryContainsKey it should be searching for a key not value (KVTDecompressionProperty_DeinterlaceMode_Temporal is not a key).
Secondly, deinterlacing does not work anyway. I can see no discernible difference when an interlaced file is played whether the VT deinterlacing is enabled or not. Either way I see jagged edges.
Here is my test file
https://www.dropbox.com/s/ykxi7p48feb3cza/sample_directv_cnn.ts?dl=0
Thirdly, here is the contents of my supported properties dictionary:
ClientPID ColorPrimaries DecoderFirstMbInRefreshedSlices DecoderFirstMbInSkipSlices DecoderUsage FieldMode PropertyType Enumeration ReadWriteStatus ReadWrite SupportedValueList DeinterlaceFields BothFields ICCProfile MaxAgeForOutputPixelBufferPool MaxOutputPresentationTimeStampOfFramesBeingDecoded MinOutputPresentationTimeStampOfFramesBeingDecoded NumberOfFramesBeingDecoded OnlyTheseFrames PropertyType Enumeration ReadWriteStatus ReadWrite SupportedValueList OnlyTheseFrames AllFrames OnlyTheseFrames NonDroppableFrames OnlyTheseFrames IFrames OnlyTheseFrames KeyFrames OutputPoolRequestedMinimumBufferCount PixelBufferPool PixelBufferPoolIsShared PixelTransferProperties PoolPixelBufferAttributes PoolPixelBufferAttributesSeed Priority RealTime SuggestedQualityOfServiceTiers ThrottleForBackground TransferFunction UsingHardwareAcceleratedVideoDecoder UsingSandboxedVideoDecoder YCbCrMatrixAs you can see there is no mention of deinterlacing mode which seems odd for latest gen hardware/OS. I don't know if this relates to lack of deint working in VLC because even if you don't set the deint mode it is supposed to default to Vertical Filter, but as I say I see no evidence of any deinterlacing going on.