metadata: local files are incorrectly "downloaded" and put in cache
Given a sample such as the below, both 2.2.x
and latest trunk mistakenly decides that the artwork requires a download; meaning that local art is effectively just copied from one place to another.
proof-of-concept
/tmp/poc% ls
cover.png foo.m3u sample.mp3
/tmp/poc% md5sum cover.png
5a2f494254550c750d710824d34c3754 cover.png
/tmp/poc% cat foo.m3u
#EXTM3U
#EXTINF:1,...hello world
#EXTALBUMARTURL:FILE:///tmp/poc/cover.png
/tmp/poc/sample.mp3
/tmp/poc% rm -rf ~/.cache/vlc/
/tmp/poc% vlc -q -Irc foo.m3u
VLC media player 2.2.4 Weatherwax (revision 2.2.3-37-g888b7e89)
VLC media player 2.2.4 Weatherwax
Command Line Interface initialized. Type `help' for help.
> info
+----[ Stream 0 ]
|
| Type: Audio
| Bitrate: 128 kb/s
| Codec: MPEG Audio layer 1/2 (mpga)
| Channels: Stereo
| Sample rate: 44100 Hz
|
+----[ end of stream info ]
> quit
Shutting down.
/tmp/poc% find ~/.cache/vlc -type f -exec md5sum {} \;
5a2f494254550c750d710824d34c3754 /home/refp/.cache/vlc/art/arturl/1f04c7d2df971c07a8f1607f4dc3f3d2/art.png
Notice how the md5sum
of the cached art is that of cover.png
.