3.0 regression: MP4 demuxer segfaults
On regular MP4 file:
../../modules/demux/mp4/meta.c:190:14: runtime error: null pointer passed as argument 2, which is declared to never be null
Thread 15 "vlc" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffcd61a700 (LWP 10429)]
0x00007ffff6e837d0 in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.3
(gdb) bt
[#0](https://code.videolan.org/videolan/vlc/-/issues/0) 0x00007ffff6e837d0 in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.3
[#1](https://code.videolan.org/videolan/vlc/-/issues/1) 0x00007fffdb18d83d in AppleNameToMeta (
name=0x6040000734a4 "player.version", meta_type=0x7fffcd6194f0,
meta_key=0x7fffcd619530) at ../../modules/demux/mp4/meta.c:190
[#2](https://code.videolan.org/videolan/vlc/-/issues/2) 0x00007fffdb18e233 in SetMeta (p_meta=0x6110000697c0, i_type=0,
name=0x6040000734a4 "player.version", p_box=0x60b000338e30)
at ../../modules/demux/mp4/meta.c:226
[#3](https://code.videolan.org/videolan/vlc/-/issues/3) 0x00007fffdb18fe08 in SetupmdtaMeta (p_meta=0x6110000697c0,
p_box=0x60b000338e30, p_keys=0x60b000338f90)
at ../../modules/demux/mp4/meta.c:359
[#4](https://code.videolan.org/videolan/vlc/-/issues/4) 0x00007fffdb1901de in SetupMeta (p_meta=0x6110000697c0,
p_udta=0x60b000338ee0) at ../../modules/demux/mp4/meta.c:391
[#5](https://code.videolan.org/videolan/vlc/-/issues/5) 0x00007fffdb0d53f4 in Control (p_demux=0x6130000341f8, i_query=261,
args=0x7fffcd619ab0) at ../../modules/demux/mp4/mp4.c:1789
[#6](https://code.videolan.org/videolan/vlc/-/issues/6) 0x00007ffff41e0309 in demux_vaControl (demux=0x6130000341f8, query=261,
args=0x7fffcd619ab0) at ../../src/input/demux.c:453
[#7](https://code.videolan.org/videolan/vlc/-/issues/7) 0x00007ffff421f57a in demux_Control (p_demux=0x6130000341f8, i_query=261)
at ../../include/vlc_demux.h:358
[#8](https://code.videolan.org/videolan/vlc/-/issues/8) 0x00007ffff42391e6 in InputSourceMeta (p_input=0x61d0000a9738,
p_source=0x61200009bf78, p_meta=0x6110000697c0)
at ../../src/input/input.c:2486
[#9](https://code.videolan.org/videolan/vlc/-/issues/9) 0x00007ffff422c50c in Init (p_input=0x61d0000a9738)
at ../../src/input/input.c:1350
[#10](https://code.videolan.org/videolan/vlc/-/issues/10) 0x00007ffff4224305 in Preparse (data=0x61d0000a9738)
at ../../src/input/input.c:515
[#11](https://code.videolan.org/videolan/vlc/-/issues/11) 0x00007ffff5be3464 in start_thread (arg=0x7fffcd61a700)
at pthread_create.c:333
[#12](https://code.videolan.org/videolan/vlc/-/issues/12) 0x00007ffff57229df in clone ()
at ../sysdeps/unix/sysv/linux/x86_64/clone.S:105
3089fda2ee67f2a3766a26faf221e3735664abbc is the first bad commit
commit 3089fda2ee67f2a3766a26faf221e3735664abbc
Author: Filip Roséen <filip@atch.se>
Date: Wed Nov 16 11:37:06 2016 +0100
demux/mp4: meta: replace usage of legacy helpers
Replace the usage of legacy helpers with ones where common
functionality is shared, effectively avoiding code-duplication.
Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>
:040000 040000 03c02e4d583dda3f2a08c33b9b530b75d118e2ac 82c0d5f97aa24aeef3338474b197fb48ab5dd192 M modules