3.0 regression: the adaptive demuxer hangs on m3u8 over http

added Severity::normal Type::bug Version::master git + 1 deleted label

changed milestone to %Bugs paradize

changed title from m3u8 not play to 3.0 regression: the adaptive demuxer hangs on m3u8 over http

changed the description

added Component::Demuxers label and removed 1 deleted label

In 3.0.0 git version this not work.

modules/adaptive/demux will get stuck reading for an infinite period of time because it tells the remote resource that HTTP/1.1 shall be used, and that Transfer-Encoding: chunked is an acceptable reply.

The module does, as far as I can tell, not handle the mentioned transfer-encoding, causing it to wait for the socket to close (the way HTTP/1.0) signaled that a resource was finished with its transfer (if Content-Length is not available).

patch (mostly to show the underlying problem)

diff --git a/modules/demux/adaptive/http/HTTPConnection.cpp b/modules/demux/adaptive/http/HTTPConnection.cpp
index 7c6d07b..3514ad3 100644
--- a/modules/demux/adaptive/http/HTTPConnection.cpp
+++ b/modules/demux/adaptive/http/HTTPConnection.cpp
@@ -277,7 +277,7 @@ void HTTPConnection::onHeader(const std::string &key,
 std::string HTTPConnection::buildRequestHeader(const std::string &path) const
 {
     std::stringstream req;
-    req << "GET " << path << " HTTP/1.1\r\n" <<
+    req << "GET " << path << " HTTP/1.0\r\n" <<
            "Host: " << params.getHostname() << "\r\n" <<
            "Cache-Control: no-cache" << "\r\n" <<
            "Accept-Encoding: identity" << "\r\n" <<

By using HTTP/1.0 instead of HTTP/1.1 we force the remote resource to either close the socket when the transfer is complete, or to include Content-Length in the reply (so we know when it is done).