nigthlies broken after the asa subtitles merge
If I try to build the latest nighly from http://nightlies.videolan.org/build/source/ I get:
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DSYS_LINUX -I../../include -I../../include -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DLOCALEDIR=\"/usr/share/locale\" -DDATA_PATH=\"/usr/share/vlc\" -DPLUGIN_PATH=\"/usr/lib64/vlc\" -D__LIBVLC__ -D__PLUGIN__ -DMODULE_NAME=asademux -DMODULE_NAME_IS_asademux -O0 -fvisibility=hidden -march=athlon64 -O2 -pipe -g -ggdb -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wcast-align -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -MT libasademux_plugin_la-subtitle_asa.lo -MD -MP -MF .deps/libasademux_plugin_la-subtitle_asa.Tpo -c subtitle_asa.c -fPIC -DPIC -o .libs/libasademux_plugin_la-subtitle_asa.o
subtitle_asa.c:46:22: error: asademux.h: No such file or directory
subtitle_asa.c: In function ‘Open’:
subtitle_asa.c:173: error: ‘asa_det_first’ undeclared (first use in this function)
subtitle_asa.c:173: error: (Each undeclared identifier is reported only once
subtitle_asa.c:173: error: for each function it appears in.)
subtitle_asa.c:173: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:175: error: dereferencing pointer to incomplete type
subtitle_asa.c:201: warning: implicit declaration of function ‘asa_imports_detect’
subtitle_asa.c:201: warning: assignment makes pointer from integer without a cast
subtitle_asa.c:210: error: dereferencing pointer to incomplete type
subtitle_asa.c:212: warning: too few arguments for format
subtitle_asa.c:216: error: dereferencing pointer to incomplete type
subtitle_asa.c:233: warning: implicit declaration of function ‘asa_import’
subtitle_asa.c:252: error: dereferencing pointer to incomplete type
subtitle_asa.c:252: error: ‘ASAI_TARGET_SSA’ undeclared (first use in this function)
subtitle_asa.c: In function ‘ProcessLine’:
subtitle_asa.c:269: warning: unused parameter ‘p_arg’
distcc[13371] ERROR: compile subtitle_asa.c on localhost failed
make[4]: *** [libasademux_plugin_la-subtitle_asa.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
There are two causes of this:
-
asa headers are not included in the 'make dist' target. I'll attach a patch to Modules.am
-
the --disable-asademux option of configure does nothing. I'll attach a patch too.
Both issues are trivial so I don't think opening two tickets is worth it.
By the way, the comments about "default disabled" for asa stuff in configure seem wrong as they are enabled as soon as the required dependencies are found.