External MKV chapter plays only once per video window

MKV files with externally referenced chapters only play an externally referenced chapter once per video window.

Example VIDEO.mkv file chapters: Prologue Opening (references OP.mkv in the same directory) Episode Ending (references ED.mkv in the same directory) Preview

Playing OP.mkv or ED.mkv by themselves works without any problems.

Playing VIDEO.mkv from time=0 goes through the Prologue, plays the Opening, plays the Episode, then halts on the last frame of Episode. Seeking does not resume playback. Play/pause buttons unresponsive. Must close the video window to continue.

Playing VIDEO.mkv from time=middle_of_Episode goes through the Episode, plays the Ending, plays the Preview. Jumping to t=0 before the video ends and closes, causes the Prologue to play and halts on its last frame. The Opening does not play. Seeking does not resume playback. Play/pause buttons unresponsive. Must close the video window to continue.

Disabling the "Preload MKV files in the same directory" setting keeps the external chapters from loading, but video playback does play through the chapter transitions (Prologue -> Episode -> Preview).

Problem does not show up in 2.2.1 downloaded from the videolan homepage. That version plays the external chapters without any problems.

Tested on Mac OS X 10.10.3 with a git master compiled locally and vlc-3.0.0-x86_64-20150423-0111.zip nightly.

Playing VIDEO.mkv from time=0 goes through Prologue, plays the Opening, plays the Episode. Jumping to t=0 before the Ending starts causes the Prologue to play and halts on its last frame. The Opening does not play again. Seeking does not resume playback. Play/pause buttons unresponsive. Must close the video window to continue

Uploaded a minimal set of MKV files to streams.videolan.org: mkv_chapter_test_files.zip

A run down with git bisect suggests that the problem was introduced in commit 557eaa06:

git bisect log
git bisect start
# bad: [ccc530cd5f1fb1ffb7498cd06186b673f707552d] vaapi: fix unbalanced initialization and simplify
git bisect bad ccc530cd5f1fb1ffb7498cd06186b673f707552d
# good: [70d44c22d0c3ec84363b17d437b5bdd7aced91c4] demux: ts: only set self pcr to its program
git bisect good 70d44c22d0c3ec84363b17d437b5bdd7aced91c4
# bad: [b209b71e924a90e8fe1d753b31dfbca4cdafe0bf] demux: ts: set data type on stream handling
git bisect bad b209b71e924a90e8fe1d753b31dfbca4cdafe0bf
# good: [34e54feea7de9f75e6b2085df4a12235a516571a] macosx: fix main menu initialization order on startup
git bisect good 34e54feea7de9f75e6b2085df4a12235a516571a
# bad: [1dcc337d1f41bb760d72118849d53c3856d030ca] D3D11: use defines for DXGI
git bisect bad 1dcc337d1f41bb760d72118849d53c3856d030ca
# bad: [98748a4a98cefe26451a93b6deb646dbdb8d4366] shine: avoid double free
git bisect bad 98748a4a98cefe26451a93b6deb646dbdb8d4366
# bad: [0eba4c32a03ab96ea54457a95496d01160d851b5] vlc_bits: use vlc_common and guards against failed realloc
git bisect bad 0eba4c32a03ab96ea54457a95496d01160d851b5
# good: [5a234320bf53cfc0121477ca538c087790c94899] decoder: do not mix and match condidition variable and mutex pairings
git bisect good 5a234320bf53cfc0121477ca538c087790c94899
# good: [90a41800049ec54a0191613fdfb37c3338d9d297] aout: add wait parameter to aout_DecFlush()
git bisect good 90a41800049ec54a0191613fdfb37c3338d9d297
# bad: [a308b7a17466bb91908a518c93b36dacb49212e7] aout: remove aout_DecIsEmpty()
git bisect bad a308b7a17466bb91908a518c93b36dacb49212e7
# bad: [557eaa06dc5babd74d766b8894086cdcb1a33c44] decoder: drain the audio output properly
git bisect bad 557eaa06dc5babd74d766b8894086cdcb1a33c44
# first bad commit: [557eaa06dc5babd74d766b8894086cdcb1a33c44] decoder: drain the audio output properly

I don't see how an audio commit can destroy MKV playback.

Audio tracks removed from all sections: video plays all the way through. Subjectively, it seems to transition more smoothly.

Audio tracks removed from the main MKV, but not the opening and ending files: video plays through the Prologue, plays the Opening, then halts.

Audio tracks removed from the opening and ending files, but not the main MKV: video halts at the end of the Prologue.

Uploaded a new set of MKV test files that include the no-audio versions to streams.videolan.org: mkv_chapter_test_files.zip . This file should replace the previous upload.

http://streams.videolan.org/issues/14453/

3.0 regression.

changed milestone to %3.0.0

added 1 deleted label

assigned to @robUx4

added Status::fixed label

closed

Milestone renamed

changed milestone to %3.0 FF

Milestone renamed