Closed captions gets stuck or doesn't work at all. high CPU usage when mpeg2 ts file

I am having a lot of problem with legacy Closed captions for a while now. This one is even worst since it will either get stuck on one or it will stop. I am attaching the log. Using vlc-3.0.0-git-20150317-1132

Added attachment:

• Closed captions gets stuck or doesn't work with high CPU usage when mpeg2 ts file.log

assigned to @fcartegnie

added Component::Demuxers: TS label

Please share the file!

Hello. I had to upload the ts file due to being a huge file. Please delete after testing it with vlc-3.0.0-git-20150317-1132 https://drive.google.com/file/d/0B0zO7r20KDJVRnNxbmpwaDVGS1k/view?usp=sharing

That's a negative offset between the timestamps & CC data gathering at mpeg2video decoder level, and the demuxer PCR.

That offset exists in 2.2 as well. Works there.

The deocder thread does the vout_PutSubpicture for the CC spu but the control queue / vout_control_Pop is only executed on thread exit.

bisection gives commit b8c35c76

[00007fefb0022f58] core subpicture error: subpicture heap full

added Component::Core: Video output label and removed Component::Demuxers: TS label

commit 93e1d6ad Author: Thomas Guillem thomas@gllm.fr Date: Wed Mar 25 15:27:36 2015 +0000

video_output: fix controls and events not processed

This issue is easily reproducible with VDPAU activated, with a 60fps ts file,
see [#14199](https://code.videolan.org/videolan/vlc/-/issues/14199).

With this sample, The video_output Thread is looping in ThreadDisplayPicture
way more often than with other videos. Consequently, vout_ManageWrapper and
ThreadControl are not called enough. As a result, subtitles are processed too
late, the mouse isn't able to hide/unhide, we can be stuck in fullscreen mode,
or second click on video to pop up the menu doesn't work.

To fix this issue: don't loop in ThreadDisplayPicture and don't wait in
vout_control_Pop if a picture was previously displayed.

Fixes [#14199](https://code.videolan.org/videolan/vlc/-/issues/14199)

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Original author: thomas@gllm.fr

added Status::fixed label

closed

Milestone renamed

changed milestone to %3.0 FF

Milestone renamed