Windows: XPI installation is broken

There are some issues which breaks the xpi installation:

• The files libvlc.dll, libvlccore.dll and npvlc.dll are missing (the associated manifest files aren't missing)
• The XPI installation must be unpacked by the browser. Adding the following line into the file "install.rdf" will unpack the extension: "em:unpacktrue</em:unpack>"
• The folder structure is wrong. The plugin will crash. The correct structure is:

install.rdf
plugins/
    libvlc.dll
    libvlc.dll.manifest
    libvlccore.dll
    npvlc.dll
    npvlc.dll.manifest
    plugins/
        access
        access_output
        ...

A manually repaired xpi installation works fine for me with Firefox 31.

Manifest file

Added attachment:

• install.rdf.in.diff

Changes in package.mak

Added attachment:

• package.mak.diff

I have now tried to fix the issues. With the changes in the attached files it works fine for me, but I don't know if my solution in the package.mak is the best way.

Accepted.

added Status::fixed label

changed milestone to %2.2.0

closed

commit 70e21214 Author: Jean-Baptiste Kempf jb@videolan.org Date: Sat Aug 2 21:26:08 2014 +0200

Win32: Correctly layout the files for the XPI

Close [#11856](https://code.videolan.org/videolan/vlc/-/issues/11856)

Original author: jb@videolan.org

Second changes

Added attachment:

• package.mak.2.diff

I have attached a second patch, which will copy all additional needed dlls, too. (libstdc++-6.dll, libgcc_s_sjlj-1.dll, ...) I hope this solution is reliable, if not, you can close this ticket again ;)

removed Status::fixed label

reopened

No, because they won't work in all cases. You should link those statically.

added Status::fixed label

closed

A little question: Is it wanted that the platform is not specified in the filename of the xpi package?

Don't think so.

Changes

Added attachment:

• package.mak.3.diff

Replying to [comment:7 jb]:

Don't think so. package.mak.3.diff​ would fix this ;)

Done.