Commits on Source (4)
-
Rémi Denis-Courmont authored
This function does not work with MMDevice and PulseAudio, and does not support hot-plug. To enumerate devices, the newer function libvlc_audio_output_device_enum() ought to be used, which also works with MMDevice and PulseAudio, and track audio device events. No amount of documentational warnings will save developers from using this broken function. It is better to remove it now that there is the opportunity to do so in the form of the LibVLC 4.0 binary compatibility break.
e0ed4601 -
Rémi Denis-Courmont authored2be8d2d0
-
Rémi Denis-Courmont authored
Historically this function would set the device for a specified audio output module. This required the application to somehow "know" what audio output module it wanted to use, which is very suboptimal for forward compatibility and portability. Worse yet, this design failed outright in VLC 2.2 with the addition of MMDevice and PulseAudio. This lead to the convention of leaving the module parameter NULL to change the device of the currently active audio output. As with the removal of libvlc_audio_output_device_list_get(), it seems saner to simply remove the old broken semantics.
fd345221 -
Rémi Denis-Courmont authored
libvlc_audio_output_set() had no practical effects as the audio output was consistently created before the application had the opportunity to select a non-default module. This fixes it. An alternative would be to remove the function entirely. Exposing module names to LibVLC applications is bad design.
ce7cc9dd
Showing
- include/vlc/libvlc_media_player.h 23 additions, 50 deletionsinclude/vlc/libvlc_media_player.h
- lib/audio.c 7 additions, 54 deletionslib/audio.c
- lib/libvlc.sym 0 additions, 1 deletionlib/libvlc.sym
- test/libvlc/core.c 0 additions, 14 deletionstest/libvlc/core.c
- test/libvlc/media_player.c 1 addition, 1 deletiontest/libvlc/media_player.c