Commits on Source (4)
-
This replaces almost all use of `SIGNAL()` and `SLOT()` with Qt5-style strongly-typed connections. The `CONNECT()`, and `DCONNECT()` helpers built around them have been removed. Cases involving the `BUTTON_*` macros will be tackled in a separate commit to improve clarity. A few cases remain using `SIGNAL()` and `SLOT()` for now due to complications that should be dealt with separately.
eb0b785f -
``` ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp: In constructor 'SPrefsPanel::SPrefsPanel(qt_intf_t*, QWidget*, int)': WARNING : ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:811: 52: 'void QButtonGroup::buttonClicked(int)' is deprecated: Use QButtonGroup::idClicked(int) instead [-Wdeprecated-declarations] 811 | connect( radioGroup, QOverload<int>::of(&QButtonGroup::buttonClicked), | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QButtonGroup:1, from ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:44: /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qbuttongroup.h:90:10: note: declared here 90 | void buttonClicked(int); | ^~~~~~~~~~~~~ ```
19d51ba2 -
I included adaptation here of a few existing cases using a different solution to the helper defines suggested in review. Example warning: ``` ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp: In constructor 'SPrefsCatList::SPrefsCatList(qt_intf_t*, QWidget*)': WARNING : ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:254: 40: 'void QSignalMapper::mapped(int)' is deprecated: Use QSignalMapper::mappedInt(int) instead [-Wdeprecated-declarations] 254 | connect( mapper, QOverload<int>::of(&QSignalMapper::mapped), this, &SPrefsCatList::switchPanel ); | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/QSignalMapper:1, from ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:45: /usr/include/x86_64-linux-gnu/qt5/QtCore/qsignalmapper.h:71:10: note: declared here 71 | void mapped(int); | ^~~~~~ ```
30618b6a -
77b75273
Showing
- modules/gui/qt/dialogs/epg/EPGWidget.cpp 10 additions, 11 deletionsmodules/gui/qt/dialogs/epg/EPGWidget.cpp
- modules/gui/qt/dialogs/epg/epg.cpp 7 additions, 7 deletionsmodules/gui/qt/dialogs/epg/epg.cpp
- modules/gui/qt/dialogs/errors/errors.cpp 3 additions, 3 deletionsmodules/gui/qt/dialogs/errors/errors.cpp
- modules/gui/qt/dialogs/extended/extended.cpp 10 additions, 10 deletionsmodules/gui/qt/dialogs/extended/extended.cpp
- modules/gui/qt/dialogs/extended/extended_panels.cpp 117 additions, 115 deletionsmodules/gui/qt/dialogs/extended/extended_panels.cpp
- modules/gui/qt/dialogs/extensions/extensions.cpp 23 additions, 20 deletionsmodules/gui/qt/dialogs/extensions/extensions.cpp
- modules/gui/qt/dialogs/extensions/extensions_manager.cpp 6 additions, 8 deletionsmodules/gui/qt/dialogs/extensions/extensions_manager.cpp
- modules/gui/qt/dialogs/fingerprint/fingerprintdialog.cpp 4 additions, 4 deletionsmodules/gui/qt/dialogs/fingerprint/fingerprintdialog.cpp
- modules/gui/qt/dialogs/gototime/gototime.cpp 3 additions, 3 deletionsmodules/gui/qt/dialogs/gototime/gototime.cpp
- modules/gui/qt/dialogs/help/help.cpp 5 additions, 5 deletionsmodules/gui/qt/dialogs/help/help.cpp
- modules/gui/qt/dialogs/mediainfo/info_panels.cpp 13 additions, 14 deletionsmodules/gui/qt/dialogs/mediainfo/info_panels.cpp
- modules/gui/qt/dialogs/mediainfo/mediainfo.cpp 5 additions, 5 deletionsmodules/gui/qt/dialogs/mediainfo/mediainfo.cpp
- modules/gui/qt/dialogs/messages/messages.cpp 9 additions, 9 deletionsmodules/gui/qt/dialogs/messages/messages.cpp
- modules/gui/qt/dialogs/open/open.cpp 34 additions, 33 deletionsmodules/gui/qt/dialogs/open/open.cpp
- modules/gui/qt/dialogs/open/open_panels.cpp 78 additions, 72 deletionsmodules/gui/qt/dialogs/open/open_panels.cpp
- modules/gui/qt/dialogs/open/openurl.cpp 3 additions, 3 deletionsmodules/gui/qt/dialogs/open/openurl.cpp
- modules/gui/qt/dialogs/plugins/plugins.cpp 32 additions, 35 deletionsmodules/gui/qt/dialogs/plugins/plugins.cpp
- modules/gui/qt/dialogs/podcast/podcast_configuration.cpp 3 additions, 3 deletionsmodules/gui/qt/dialogs/podcast/podcast_configuration.cpp
- modules/gui/qt/dialogs/preferences/complete_preferences.cpp 1 addition, 1 deletionmodules/gui/qt/dialogs/preferences/complete_preferences.cpp
- modules/gui/qt/dialogs/preferences/preferences.cpp 12 additions, 17 deletionsmodules/gui/qt/dialogs/preferences/preferences.cpp