Commits on Source (20)
-
The first if branch is already terminating with a return, so there is no need for an else branch. It makes the early return path more readable by listing the condition where the clock is not ready among the other condition where buffering is not ready.
e5dfc4f5 -
The first if branch is already terminating with a return, so there is no need for an else branch.
5584bf9b -
The first if branch is already terminating with a return, so there is no need for an else branch and we can keep only the if. The return in the branch is also superfluous given that the success path is the same.
66c64c0c -
The if else block is followed by a single return, but the else block is much more complex than the if block. To simplify, we can add the early return to the first branch as an early success, ie. there is no other handling necessary for PCR if buffering is still enabled.
c39d5b4a -
Like the previous commit, handle the case when buffering is enabled with an early return instead of branching in the case where it's disabled, in order to remove the whole indentation level and specify exit conditions at the beginning of the case.
8af10a9e -
Like the previous commit, handle the case when clock settings need to be changed with an early return instead of branching in the case where the parameters need to be changed, in order to remove the whole indentation level and specify exit conditions at the beginning.
668d7cb6 -
The variable was only written once and then returned.
1142148b -
The branches are redundants
e5961e9c -
As done in multiple places for deallocation, prefer exiting the release function in case of non-null reference count instead of branching the whole function to reduce indentation level and complexity.
f9cffc08 -
Use the early return on the !b_record path where it cannot fail (release of resources) and which is much simpler than the b_record path which needs to handle errors.
22d83dc4 -
b86e4a92
-
Remove an indentation level by explicitely skipping the non-matching es.
145c5e99 -
dae60ffb
-
e2b9a9ab
-
Skip the ES explicitely from the beginning of the loop instead of skipping implicitely with branching, removing an indentation level and making the skip condition clearer.
21af7911 -
Explicitely skip NULL decoder instead of branching the whole loop to implicitely skip them.
4834e113 -
298d563a
-
Mergin the two nested if branch removes an indentation level.
cd5b0e16 -
Returning early removes the indentation level and makes it easy to read that an allocation has been done and must be freed.
36c779d0 -
There is no real reason to inverse them in this case, but other cases in the files are now returning when they succeed in generating the string, and fallback to other methods when they cannot generate it.
ed5f57a1