Commits on Source (5)
-
The commit patches src/icy.c and src/legacy.c to include <stdlib.h> or <stdio.h>, so as to avoid FTBFS where free(), malloc(), and snprintf() have no valid prototype before usage.
85268b42 -
cb5d59c9
-
It makes the call more readable, the line less long for the change into shout_set_content_format, and it makes it easier to potentially change the format later.
1b651397 -
The shout_set_name/description/genre/url were deprecated[^1] in 2.4.0, whereas the new shout_set_meta was added[^2] ten years ago which already commented the previous function as obsolete. [^1]: https://github.com/xiph/Icecast-libshout/commit/559e61ec7a1a02f2da6e7a2bfadfdb1b1147cccd [^2]: https://github.com/xiph/Icecast-libshout/commit/932a7742213c0aa4c8f87da4fac32b16c6641ff3 Fixes the following warnings: ../../modules/access_output/shout.c: In function ‘Open’: ../../modules/access_output/shout.c:211:10: warning: ‘shout_set_name’ is deprecated: use shout_set_meta() with SHOUT_META_NAME [-Wdeprecated-declarations] 211 | || shout_set_name( p_shout, psz_name ) != SHOUTERR_SUCCESS | ^~ In file included from ../../modules/access_output/shout.c:53: /usr/include/shout/shout.h:348:5: note: declared here 348 | int shout_set_name(shout_t *self, const char *name) SHOUT_ATTR_F_DEPRECATED("use shout_set_meta() with SHOUT_META_NAME"); // obsolete | ^~~~~~~~~~~~~~ ../../modules/access_output/shout.c:212:10: warning: ‘shout_set_description’ is deprecated: use shout_set_meta() with SHOUT_META_DESCRIPTION [-Wdeprecated-declarations] 212 | || shout_set_description( p_shout, psz_description ) != SHOUTERR_SUCCESS | ^~ /usr/include/shout/shout.h:357:5: note: declared here 357 | int shout_set_description(shout_t *self, const char *description) SHOUT_ATTR_F_DEPRECATED("use shout_set_meta() with SHOUT_META_DESCRIPTION"); // obsolete | ^~~~~~~~~~~~~~~~~~~~~ ../../modules/access_output/shout.c:213:10: warning: ‘shout_set_genre’ is deprecated: use shout_set_meta() with SHOUT_META_GENRE [-Wdeprecated-declarations] 213 | || shout_set_genre( p_shout, psz_genre ) != SHOUTERR_SUCCESS | ^~ /usr/include/shout/shout.h:354:5: note: declared here 354 | int shout_set_genre(shout_t *self, const char *genre) SHOUT_ATTR_F_DEPRECATED("use shout_set_meta() with SHOUT_META_GENRE"); // obsolete | ^~~~~~~~~~~~~~~ ../../modules/access_output/shout.c:214:10: warning: ‘shout_set_url’ is deprecated: use shout_set_meta() with SHOUT_META_URL [-Wdeprecated-declarations] 214 | || shout_set_url( p_shout, psz_url ) != SHOUTERR_SUCCESS | ^~ /usr/include/shout/shout.h:351:5: note: declared here 351 | int shout_set_url(shout_t *self, const char *url) SHOUT_ATTR_F_DEPRECATED("use shout_set_meta() with SHOUT_META_URL"); // obsolete | ^~~~~~~~~~~~~
13b7adb9 -
The version 2.4.3 added[^1] support for setting format usage, and codecs which deprecates the previous way of setting the format. The version 2.4.3 is currently available in bullseye (but not in buster). [^1]: https://github.com/xiph/Icecast-libshout/commit/0ac03fde3bf40c5c79eb2a77f0105742ed62c047 Fixes the following warnings: ../../modules/access_output/shout.c:233:5: warning: ‘shout_set_format’ is deprecated: Use shout_set_content_format() [-Wdeprecated-declarations] 233 | i_ret = shout_set_format( p_shout, var_GetBool( p_access, SOUT_CFG_PREFIX "mp3" ) ? | ^~~~~ /usr/include/shout/shout.h:361:5: note: declared here 361 | int shout_set_format(shout_t *self, unsigned int format) SHOUT_ATTR_F_DEPRECATED("Use shout_set_content_format()"); // obsolete | ^~~~~~~~~~~~~~~~
1acf4ffa
Showing
- configure.ac 1 addition, 1 deletionconfigure.ac
- contrib/src/shout/SHA512SUMS 1 addition, 1 deletioncontrib/src/shout/SHA512SUMS
- contrib/src/shout/add-missing-stdlib-stdio.patch 22 additions, 0 deletionscontrib/src/shout/add-missing-stdlib-stdio.patch
- contrib/src/shout/libshout-arpa.patch 0 additions, 25 deletionscontrib/src/shout/libshout-arpa.patch
- contrib/src/shout/no-examples.patch 0 additions, 11 deletionscontrib/src/shout/no-examples.patch
- contrib/src/shout/rules.mak 4 additions, 5 deletionscontrib/src/shout/rules.mak
- contrib/src/shout/shout-strings.patch 0 additions, 24 deletionscontrib/src/shout/shout-strings.patch
- modules/access_output/shout.c 8 additions, 6 deletionsmodules/access_output/shout.c
contrib/src/shout/no-examples.patch
deleted
100644 → 0