Commits on Source (8)
-
Rémi Denis-Courmont authored
So far, the display was created without a requested size. Then its size was immediately changed to that of the window. With this change, the display is created directly with the correct size. This matches the core video output behaviour.
3b77d4bb -
Rémi Denis-Courmont authored
In practice, this function is used to compensate mismatches between the source format SAR and the display PAR and should only be based on those parameters and the source format visible dimensions. Indeed, in the two call sites of the function pass 0x0 as the display size. In the vout_display_New() call site, the function is used to work-around semi-broken window providers that do not provision a window size, or only do so with a delay. Normally, it just copies the dimensions from window_props. Either way cfg->display dimensions are always zeroes. Furthermore, the 3 hereto unused and hereby removed cases failed to account for orientation correctly: from_source should have been false.
dfe512fe -
Rémi Denis-Courmont authored
This is no longer necessary.
e84106dc -
Rémi Denis-Courmont authored
Only from vout_display_New() can (and should) the window size be used rather than the ideal default display size. In the other call sites, we actually want to compute the ideal size regardless of the actual window size. Take that case out of vout_display_GetDefaultDisplaySize() to enable further refactoring. This is a non-functional change, except for the added run-time warning.
958d2f56 -
Rémi Denis-Courmont authored494ab046
-
Rémi Denis-Courmont authored
...rather than cfg.window_props. cfg.display was unused (always zeroes) on vout_display_New() until this change. This is consistent with vout_display_SetSize() affecting cfg.display rather than cfg.window_props.
20abc11d -
Rémi Denis-Courmont authored
No functional changes.
aaad9f9e -
Rémi Denis-Courmont authored
They were always zeroes.
39c63441
Showing
- include/vlc_vout_display.h 0 additions, 12 deletionsinclude/vlc_vout_display.h
- modules/video_output/splitter.c 5 additions, 2 deletionsmodules/video_output/splitter.c
- src/video_output/display.c 12 additions, 44 deletionssrc/video_output/display.c
- src/video_output/video_output.c 2 additions, 2 deletionssrc/video_output/video_output.c