It's automatically added.
Reverts d58a6450.

The issue was fixed in 4.0 via c94b09485811b58a49e6769943509880922ff0bd.

They are supposed to match HOSTCONF but ffmpeg refuses
options it doesn't understand.

This should compile fine on recent NDK or it should be merged upstream.

Using none should have the same effect and uses the standard FFmpeg options.

It's not supposed to work in UWP without forcing the FAMILY_DESKTOP.

It messes with the source folder location.

This is the latest in the 6.x branch.
We already build with 6.1 in the Debian unstable Docker.

This is the latest in the 5.x branch.

Khalid Masum authored 1 year ago and Steve Lhomme committed 1 year ago

ffmpeg libraries ie. avcodec, avformat, swscale and postproc were
disabled for emscripten shared compilation as ffmpeg was not built
with position independent code.

Enable pic for ffmpeg, and ultimately enable those libraries
shared compilation.

Martin Storsjö authored 2 years ago and Steve Lhomme committed 2 years ago

This fixes building with modern Clang for 32 bit architectures.
Integer/pointer conversion issues (visible on 32 bit architectures)
that only are warnings in older compilers have been made hard errors
in recent versions of Clang.

This issue appeared in VLC after ffmpeg was updated to the 5.1 version.

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Remove 3 patches that were upstreamed.
Remove `--disable-avresample` since the library is gone now.

Johannes Kauffmann authored 2 years ago and Felix Paul Kühne committed 2 years ago

This switches the FFmpeg URL from http to https, and switches the
x262 URL from git to https. No changes for nvcodec.

Steve Lhomme authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

According to #24678 it should work with Clang 5 and above. Not sure there are
iOS/XCode toolchain still available that can target iOS 9 with an older Clang.

The iOS armv7 target continues to build assembler as before.

There are proper release tarballs that we can use. It's must faster to get and
extract than git. If we need new upstream patches we can cherry-pick them until
the next release, like other contribs.

Steve Lhomme authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

This is strictly identical to the previous situation since HAVE_NEON is
set during bootstrapping on iOS only for armv7 targets anyway.

The commit prepares the removal of the HAVE_NEON flag completely in later
commits, which is redundant with armv7 check since we don't support
non-neon-capable armv7 targets anymore.

This is the default, and has no actual effects. The FFmpeg configure
script will check if NEON is supported *unless* given --disable-neon is
passed.

By comparison, the ARMv6 condition below is correct (at least in this
respect) in forcefully disabling NEON.

If the contrib install sub-directories it may install some and fail later. We
should only install when we know everything built correctly.

Do each build step in a separate make line.

In particular with the "lavc/pthread_frame: always transfer stashed hwaccel
state" fix for #27343

Johannes Kauffmann authored 2 years ago and Steve Lhomme committed 2 years ago

openjpeg used to be disabled with libav, but libav is gone now.

Steve Lhomme authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

So the order of build is always respected, even in case of build error.

Includes some fixes backported to 4.4.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Since relocation issues are now fixed.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

ld: error: /home/tom/work/git/vlc-android/vlc/contrib/aarch64-linux-android/lib/libavcodec.a(videodsp.o):(function ff_prefetch_aarch64: .text+0x10): relocation R_AARCH64_CONDBR19 out of range: 13363404 is not in [-1048576, 1048575]; references ff_prefetch_aarch64
>>> referenced by videodsp.S:26 (libavcodec/aarch64/videodsp.S:26)
>>> defined in /home/tom/work/git/vlc-android/vlc/contrib/aarch64-linux-android/lib/libavcodec.a(videodsp.o)
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Backport an existing patch from the master branch.

Marvin Scholz authored 2 years ago and Felix Paul Kühne committed 2 years ago

If GPL is enabled, build postproc together with ffmpeg
instead of building an ffmpeg-less ancient version with
numerous bugs.

Should fix crashes on macOS and possibly other OSes when
postproc is used.

Steve Lhomme authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Fixes #26738

Note that a newer version of FFmpeg is necessary to get actual
platform-specific acceleration. This merely allows plain C build.

Mehdi Sabwat authored 4 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This commit removes conditional code for the Nacl platform, in the contribs.