Claudio Cambra authored 2 months ago and Felix Paul Kühne committed 2 months ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 2 months ago and Felix Paul Kühne committed 2 months ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Pierre Lamot authored 2 months ago and Steve Lhomme committed 2 months ago

This avoids the menubar overlapping the CSD or being inaccessible when the
space is scarce

Prince Gupta authored 4 months ago and Steve Lhomme committed 2 months ago

use default delegates

The prefered addAction signature has changed [^1] in 6.3 [^2].
We can just set it separately once the action is created.
It also makes it easier to find shortcuts we set.

[^1] https://doc.qt.io/qt-6/qmenu-obsolete.html#addAction-4
[^2] https://doc.qt.io/qt-6.5/qwidget.html#addAction-9

It's defined as a struct.

See https://doc.qt.io/qt-6/qvariant-obsolete.html#Type-enum

See https://doc.qt.io/qt-6/qcheckbox.html#stateChanged

Apparently since it was introduced in 2408b38a

Other variants of the same function are used in the file.

Fixes #28918

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Pierre Lamot authored 2 months ago and Felix Paul Kühne committed 2 months ago

We need to explicitly disconnect signals here:

- destructor will release m_sourcesProvider

- the shared MediaSourceModel will be released

- they will notify mediaRemoved, but the slot expects the shared
  MediaSourceModel to be valid

At this point we don't care about model updates

Fatih Uzunoğlu authored 2 months ago and Felix Paul Kühne committed 2 months ago

Viewporter protocol is used for fractional scaling, and currently we do
not use the fractional scaling protocol ourselves because Qt uses it and
provides scale through the interface window.

However, Qt starts supporting fractional scale on Wayland starting with
6.5.0. If Qt version is lower than 6.5.0, it is not necessary to use the
viewporter protocol because Qt is not going to provide the fractional
scale anyway.

I don't think it is a good idea to start using the fractional protocol
ourselves to get the fractional scale, instead of Qt providing that. The
reason is the video window should use the same scale as the interface
window for video integration, and it complicates the code unnecessarily.

I have not realized this before, because I test Qt code with Qt 6.2 and
Qt 6.8, and I can not test Wayland changes on Qt 6.2 because it has never
been working for me on Wayland.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

As otherwise we load placeholder image just before the artwork url
becomes available, this does not look good because often time the
item gets preparsed quickly.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

This is really not necessary.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

Otherwise the states (fullscreen for now) is not saved.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

Qt has number of bugs that hinder using transitions properly. The worst one seems to be
add displaced, which causes items to have incorrect positions, where it is not possible
to recover from that situation.

Transition in general causes visual glitches (independent of positioning), but it seems
to be possible to recover from that by adjusting the viewport in an undetectable way.

This can be observed when there are 2-3 items in the playlist, and when a large number,
such as 30 items are inserted at the beginning of the playlist.

Instead of disabling the transitions altogether, I propose to:
1) Clear the artifact on items after items are added.
2) Disable add displaced transition, as it is not possible to recover from incorrectly
positioned delegate once it occurs. Keep move and remove displaced transition

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

This feature has not been tested properly by Qt, it often causes crashes.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

`QWindow::show()` does not necessarily care about the state
of the window, but rather uses the default behavior for the
platform.

Since we adjust the window geometry and states before the
window is shown (which is the expected behavior, as otherwise
the window would get adjusted immediately after shown), using
`QWindow::show()` potentially overrides the window states
nullifying the behavior of the interface starting maximized.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

Access was meant to be used for remote images as we stopped
using Qt Network, Qt can not retrieve remote images.

QQuickImage can handle local or resource files better for
its needs. It does not need to use an image provider for
local files.

VLCAccessImage is not good when same images loaded together.
When I add an album to the playlist, even though the items
share the same image (url), they appear to be loaded multiple
times. I assume this has something to do with VLCAccessImage
being an asynchronous provider.

With the default behavior, as long as cache is enabled, the
images are re-used when possible.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

So that context menu is not opened in the player page.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

CompositorX11, unlike others, requires explicit code to
adjust backdrop blur. When the effect gets activated at
a later time after initialization, it currently does not
have code to do the required adjustment.

This is a regression since b1e11641. I did not notice
it because I was using extended frame with CSD, where
this regression is masked.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 2 months ago

Since the output color is pre-multiplied, setting the alpha to
zero does not mean that nothing is shown. Rather, the alpha is
already factored in the RGB channels so it is respected.

As the Qt docs says, we can set the alpha to 0.0 to achieve
additive blending (S + D) that is necessary for noise effect.