Pierre Lamot authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

cf. fe2e9755

Only the first play date was handled. This is OK in most cases but not as
accurate as handling the date until the playback is truly started.

This previous commit and this commit were inspired by the pulse module.

computation is wrong and results in no GetBytes

It makes closing partically initialized VA's easier

Previously, the file name label was set before the window was actually loaded so this silently failed as the object was nil. This ensures the label to be set once the window was loaded when resuming a media item for the first time during the lifetime of the app.

Mikhail Gusarov authored 5 years ago and Felix Paul Kühne committed 5 years ago

Existing logic of storing playback position for macOS excludes positions within
first/last 5%.

This heuristic is fine for short videos, but for a longer one, say a 6-hour one,
it means the position is not stored for the first/last 18 minutes, which is a
nuisance.

This change adds an upper limit for the size of excluded positions.

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Mikhail Gusarov authored 5 years ago and Felix Paul Kühne committed 5 years ago

This refactoring is a prerequisite for the next commit that improves the
decision for long video files.

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Just because the generation was started, does not mean it succeeded, so we cannot trust the state but need to check for the URL's validity.

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

Silence -Wstringop-truncation warning.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Regression from d23b4527