Shaleen Jain authored 6 years ago and Thomas Guillem committed 6 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

It happened when the chromecast was switching to the buffering state from the
playing state.

If there is none and the stream contains some, it will be overridden in
NewPicture() otherwise the container values are used.

Fixes #21578

Co-authored-by: James Almer <jamrial@gmail.com>

Co-authored-by: James Almer <jamrial@gmail.com>

Fixes #21670

This is the default for the av1-normative branch.

This is default disabled in av1-normative.

Marvin Scholz authored 6 years ago and François Cartegnie committed 6 years ago

In case that AV1_OBUHasSizeField is false, i_header was used
uninitialized. The OBU header is always at least 1 byte and
the extension field is unrelated to the fact if a size field
exists or not.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Romain Vimont authored 6 years ago and Thomas Guillem committed 6 years ago

The player behavior has changed since this comment was written, now the
on_current_media_changed callback is called even on SetCurrentItem().

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Romain Vimont authored 6 years ago and Thomas Guillem committed 6 years ago

When an item is expanded (e.g. due to preparsing), it is replaced by its
(flatten) subitems.

The previous implementation first removed the item, then inserted its
subitems. As a consequence of the removal, the current index was reset
and the player was stopped.

Since we don't want to stop the player on item expansion, instead,
replace the item by its first subitem (if any), then insert the
remaining subitems.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Romain Vimont authored 6 years ago and Thomas Guillem committed 6 years ago

The actions to execute after a content change were factorized in
separate functions (vlc_playlist_ItemsInserted(), etc.).

These functions also updated the current media on the player. Instead,
update it separately, so that we can make several changes while
updating/invalidating the current media only once.

This paves the way to improve the implementation of
vlc_playlist_Expand().

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Romain Vimont authored 6 years ago and Thomas Guillem committed 6 years ago

Expanding an item (replacing it by its subitems) was implemented in
preparse.c, essentially because it's only used for preparsing.

For consistency, implement all functions changing the content of the
playlist in content.c. This avoids to expose internal functions
like vlc_playlist_ItemsInserted().

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

The picture is not being allocated, nor the surface. It's only about getting
the proper surface for lavc.

This is needed because runtime hardening does not automatically look
for libraries outside of the own application bundle anymore.

On Debian Buster, the idl include path is located on /usr/include/wine/wine/

This fixes the "Unable to open include file unknwn.idl" error.

On Debian Buster, the idl include path is located on /usr/include/wine/wine/

This fixes the "Unable to open include file oaidl.idl" error.

The RENDER output supports RGB chroma better in all respects. Besides,
I have not seen an X server supporting RGB XVideo formats in a decade.

Zhao Zhili authored 6 years ago and Rémi Denis-Courmont committed 6 years ago

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Janne Grunau authored 6 years ago and Rémi Denis-Courmont committed 6 years ago

fixed patch with the duplicate "#if defined ..." removed

Janne
---8<---
Some toolchains predefine _FORTIFY_SOURCE resulting in countless
_FORTIFY_SOURCE is redefined warnings. Using _FORTIFY_SOURCE without
compiler optimizations also generates warnings.
_FORTIFY_SOURCE is a reserved identifier in C99 ("All identifiers that
begin with an underscore and either an uppercase letter or another
underscore are always reserved for any use.") so the toolchain is
perfectly free to predefine it.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Martin Storsjö authored 6 years ago and Rémi Denis-Courmont committed 6 years ago

Clang doesn't support the .arch_extension directive for aarch64 at
the moment, but the same effect can be achieved by using .arch
instead.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

KO Myung-Hun authored 6 years ago and Rémi Denis-Courmont committed 6 years ago

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

breaks compressed audio / adpcm

This reverts commit 6c3bef5f.

Any object is fine.

Always provide a display "owner" structure in caller when creating a
vout display. Also use the owner data as a pointer to the owning video
output thread.