This is how it was done before 282c1827

Pierre Lamot authored 5 years ago and Steve Lhomme committed 5 years ago

By default it should be lib*.prl and *.prl for Windows non-mingw builds.

The SRC folder being relative to top contrib directory when the build starts,
if we move to other directories we need to compensate for this change.

TOPSRC_BUILT is introduced to match the contrib dir from a contrib target
folder. It will work for relative pathes and absolute pathes (where it will be
the same a TOPSRC).

pkg_static_built should be used when patching pkg-config files during the build
phase.

copy parameters are the picture ones

regression by c988b8d5

can happen without decoders

Use the local variables when possible
+ more doc on the viewpoint event

Hyeon-Ju Lee authored 5 years ago and François Cartegnie committed 5 years ago

in TrackCreateES() don't compare case of i_handler is ATOM_clcp
It makes can't create track for clcp media type
print this debug messages and vlc player can't recognize closed caption

debug messages:
    mp4 demux debug: track[Id 0x4] read 32 samples length:80s
    mp4 demux error: cannot create es for track[Id 0x4]
    mp4 demux debug: ignoring track[Id 0x4]

I tested by using this sample videos:
    https://sampleplatform.ccextractor.org/sample/download/45
    https://sampleplatform.ccextractor.org/sample/download/130

reference:
    https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html#//apple_ref/doc/uid/TP40000939-CH205-SW87


Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

The VLC_TOOLS variable can also be set in the environment in case the tools are
found elsewhere.

Editing main.mak requires a bootstrap call on Windows because ln -s makes a
hard copy of the file. With a local Makefile we can make changes and they are
used right away as on other platforms.

Empty string is invalid value, not missing object variable...

VLC_ENOVAR is for missing variable. EINVAL is VLC_EBADVAR.

...instead of going through the variable subsystem.

There are no "command" variables on the LibVLC instance object left.

With pf_block, there is, for each received packet:
- one heap allocation for the block_t,
- one memory copy from the block_t into the downstream filter/demux
  (normally the prefetch filter) in the stream core, and
- one heap free in the stream core.
And it gets worse if the packet size exceeds the MRU (1316 bytes).

In practice, the read size (from the prefetch filter) is almost always
much larger than the packet size. Using pf_read, we eliminate both the
heap manipulations and the memory copies, both for sanely sized and
insanely sized fragmented packets.

In the corner case that the read size is actually small, this uses a
circular buffer and incurs one memory copy. That is still faster than
the pf_block logic.