Skip to content
Snippets Groups Projects
  1. Aug 02, 2022
  2. Jul 29, 2022
  3. Jun 29, 2022
  4. Jun 22, 2022
  5. Jun 18, 2022
  6. Jun 17, 2022
  7. Jun 02, 2022
  8. May 27, 2022
  9. Mar 24, 2022
  10. Mar 12, 2022
  11. Mar 05, 2022
  12. Mar 03, 2022
  13. Feb 07, 2022
  14. Jan 29, 2022
  15. Jan 04, 2022
  16. Dec 15, 2021
  17. Dec 02, 2021
  18. Oct 05, 2021
    • Craig Turner's avatar
      doc: QtGL: fix textures being recreated · 180cc786
      Craig Turner authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      QOpenGLFramebufferObject::takeTexture is detaching the current texture
      and transfering ownership to the caller, and the texture was never
      destroyed afterwards. It was leading to a huge memory consumption and
      leak when using the sample app.
      
      From the documentation[^1] in Qt5:
      
          Returns the texture id for the texture attached to this framebuffer
          object. The ownership of the texture is transferred to the caller.
      
          If the framebuffer object is currently bound, an implicit release()
          will be done. During the next call to bind() a new texture will be
          created.
      
      [1]: https://doc.qt.io/qt-5/qopenglframebufferobject.html#takeTexture
      
      
      
      Co-authored-by: Alexandre Janniaux's avatarAlexandre Janniaux <ajanni@videolabs.io>
      For the commit message and cleaning the fix mostly.
      
      Fixes #25867
      180cc786
  19. Aug 20, 2021
Loading