Fatih Uzunoğlu authored 1 month ago and Steve Lhomme committed 1 month ago

We are intercepting and inhibiting the close event for several reasons:
- Idle inhibit case (not inhibiting close used to crash at least Wayland).
- Video window using resources of the interface window case (Wayland, DComp).

Furthermore for the latter case we postpone destroying the window (hence
closing) even more, to the point destroying the window does not cause harm
with regard to the video window (fdb0a981 for DComp, 6923be9b for Wayland).

Because of this, the time between user clicks on the close button and the
window effectively closes is too much for responsiveness.

I propose to hide the window until destroying (and closing) to make close
more responsive. This should be fine because hiding should not
release the resources, as the default value of
`QQuickWindow::setPersistentGraphics()` is true and we are not overriding
it and we do not expect to override it as well.

I have also checked if this would cause saving the window state as hidden
before closing. However, `QVLCTools::saveWindowPosition()` does not save\
it so it should be fine.

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

pkg-config --cflags cairo returns the path to the folder containing
cairo.h.

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

sys/shm.h is notoriously broken on android <= 26, cf android
documentation. Remove it until we have the android API level targeted
in the buildsystem.

Bionic says:

        /**
        * @file sys/shm.h
        * @brief System V shared memory. Not useful on Android because it's disallowed by SELinux.
        */

and defines the functions with the following guard:

        #if __BIONIC_AVAILABILITY_GUARD(26)

Unlike the <vlc/libvlc.h>. So we don't need to include the root of the core, including in tests.

And remove the merged android patch.

They used to be included by pupnp. They don't use/need it anymore, but we do.

Fatih Uzunoğlu authored 2 months ago and Steve Lhomme committed 1 month ago

These are not real qt modules (but qt libraries),
they are here for historical reasons as they were
useful when qmake or cmake was not used to generate
dependencies for static qt.

Fatih Uzunoğlu authored 2 months ago and Steve Lhomme committed 1 month ago

The image handler plugin is used instead of the svg module.

Fatih Uzunoğlu authored 1 month ago and Steve Lhomme committed 1 month ago

We need to take exclusive grab here, otherwise handlers
beneath that take exclusive grab may act on press.

This is the case when media library view items go under
the title bar. Unfortunately in controls we have to use
`TapHandler.ReleaseWithinBounds` as gesture policy for
the tap handlers due to a bug present in Qt 6.2.

Fatih Uzunoğlu authored 1 month ago and Steve Lhomme committed 1 month ago

As Qt 6.6 marks it as `FINAL` (without proper justification).

This is done just to fix Qt 6.6, as starting with Qt 6.7 the
property is no longer marked `FINAL`.

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

Otherwise, building on windows can fail with:

    modules/meson.build:407:17: ERROR: File file_crypt_win32.c does not exist.

Test C23 header, clang/gcc builtins and compat versions.

So the compiler can check the callers.

Rather than a local string.

Without varargs which is most of the call we use.
And it won't parse and allocate a new string each time.

MP4_BoxGet_Path must always be called with a usable path that won't
be free'd by MP4_BoxGet_Path().

The format string doesn't contain any string to replace.

It requires loading nvEncodeAPI[64].dll from the system which is not possible in UWP.

Brad Smith authored 1 month ago and Steve Lhomme committed 1 month ago

OpenBSD and NetBSD do not have qsort_r().

Alexandre Janniaux authored 2 months ago and Steve Lhomme committed 1 month ago

This allows checking that the dependency could be found, in particular
to set the enabled: flags for plugins, without first checking whether
the condition to do the lookup are met.

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

The split from 91eaf42c was missing the
static qualifier for the functions, leading to warnings.

*pi_preroll is a vlc_tick_t that can never be bigger than VLC_TICK_MAX.