Refs #21860.

When formatting a message to HTTP 1.1, chunked encoding is often
necessary. However if the input message structure is not tied to any
specific HTTP version, it cannot contain the chunked encoding, which
will only be added when formatting.

Only the iconv handle was correctly reset, potentially leading again to
wrong or inconsistent parameters.

Refs #25065

Lyndon Brown authored 5 years ago and Felix Paul Kühne committed 4 years ago

Certain sets of options in the core option set use a cat/subcat of -1 as
a "hack" to avoid those options showing up in the GUI prefs set. This is
the case for options like --help for instance. While the Qt GUI plugin
respects this, the MacOSX one was missing checks for this, and so surely
(I don't have a mac so I can't look and see) it was including them when
it shouldn't.

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Lyndon Brown authored 5 years ago and Felix Paul Kühne committed 4 years ago

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Lyndon Brown authored 5 years ago and Felix Paul Kühne committed 4 years ago

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Lyndon Brown authored 5 years ago and Felix Paul Kühne committed 4 years ago

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Lyndon Brown authored 5 years ago and Felix Paul Kühne committed 4 years ago

subCategoryItem would be null if:
 a) a plugin author neglected to place a set_category() call before one
    or more options.
 b) the first or only subcat targetted by a plugin is a general one.

there are actual examples of A with a handful of in-tree plugins (to be
fixed in a subsequent commit).

there are multiple in-tree modules which target general subcats,
including various logger and keystore plugins.

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Lyndon Brown authored 5 years ago and Thomas Guillem committed 4 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 4 years ago and Felix Paul Kühne committed 4 years ago

 - Force BGRA on macbooks not handling HEVC. This was done automatically
   before but it will likely change in the future like iOS.

 - Also force BGRA for 12 and 16bits since the openGL* implementation
   can't handle it.

This will abort should YoutubeDL get stuck waiting for network I/O.

This partially reverts commit 0b67edc9.