Prince Gupta authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

a generic ML context model

Prince Gupta authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

can be used to create native menus with support asyncronously retreive data from MLBaseModel like model

Prince Gupta authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

QtObject which supports direct children

Romain Vimont authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

Visiblity -> Visibility.

Pierre Lamot authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

this allow to keep the playlist visible when switching between the player and
the medialibrary views, regarding the different parameters (playlist docked,
playlist visible, video embed)

this uses a hierarchical state machine to track the different states and
transitions.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

It's using IID_PPV_ARGS and WRL.

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

This gives a table listing all options, similar to and inspired by the
`about:config` interface in Firefox.

Unique benefits:
 - It highlights which options have been modified from default state.
 - It allows selective resetting of individual options to default values.

Support is included to toggle booleans with a simple double-click.
Double-clicking on other types opens the edit dialog.

For colour selection items, the modify action directly opens the Qt
colour selection dialog rather than present the colour control used in
the advanced preferences view, since this is much cleaner.

Note that the existing simple and advanced views are not linked; if you
change an option in one view, that change is not reflected in the other,
and saving changes only uses the state from the selected view. The same
is currently true of the new expert mode, though I plan to later change
this behaviour (for all three).

Note also that hotkey items are deliberately excluded from this view.
The dedicated hotkey editor is best suited to managing hotkeys. It does
not work well to include the set of 224 unique hotkey options within this
table, especially since we'd have to duplicate the code checking for
duplicate assignments if we allow editing of them as with all other
option types within this interface. It may seem odd for the 'expert'
mode to be the only one without hotkey editing, however the hotkey editor
does not really fit well into 'advanced' mode either, and I have plans to
propose separating the hotkey editor entirely from within the set of
three views in a small redesign.

Fixes #18607.

Benjamin Arnaud authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

After this, groups will be hidden until we bring them back in VideoAllDisplay.

Alexandre Janniaux authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

Typos found and reworked from codespell.

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

this allows not depending on vlc_medialibrary_t being present in MLBase

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

this function allows to run lambdas on the ML thread, this should be used to
perform operation that requires to call vlc_ml_xxx functions as vlc_ml_xxx
should *not* be called from the UI thread

obj: this is the instance of the calling QObject, we ensure that this object is
still live when calling the ui callback, if this object gets destroyed the task
is canceled

mlCb: this callback is executed in a background thread (thread pool), it takes
as arguments the instance of the medialibrary, and a context, the context can be
modified to pass data to the UI callback

uiCB: this callback is executed on the Qt thread, it takes as first argument the
id of the tasks, and as second argument the context that was created for the ML
callback

queue: this allow the task to be ran on a specific thread, when this parameter
isn't provided, the task can be scheduled on any thread.

Ctx is the type of context, this context is created by the runner and passed
sequentially to the ML callback then to UI callback, the ML callback may modify
its properties as a way to pass data to the UI callback

 the ml callback **SHOULD NOT** capture the obj object or point to its
properties by reference, as the obj object may potentially be destroyed when the
function is called

the ui callback **MAY** capture the object obj as we will ensure that the object
still exists before calling the callback

the uiCb **MAY NOT** be called if the object obj is released earlier

anything stored int the context Ctx **MUST** auto release when the context is
destroyed

sample usage:

```
    //structure used to pass data from the ML thread to the UI thread
    struct Ctx {
        bool success;
    };
    m_mediaLib->runOnMLThread<Ctx>(
    //reference to the object making the call, this is used to ensure that
    //the caller still exists before calling the UI callback
    this,
    //ML thread, data needed from the caller are passed in the capture of the lambda
    //capturing this or any of its member is not allowed here
    //the callback have in parametters the ml instance and a context that will be shared with
    //the UI callback
    [url, indexed](vlc_medialibrary_t* ml, Ctx& ctx)
    {
        int res;
        if ( indexed )
            res = vlc_ml_add_folder(  ml, qtu( url ) );
        else
            res = vlc_ml_remove_folder( ml, qtu( url ) );
        ctx.success = (res == VLC_SUCCESS);
    },
    //UI callback, capturing this is allowed, (runOnMLThread will ensure that `this`
    //still exists at this point
    //the callback has as parametters the request id and the shared context
    [this, indexed](quint64, Ctx& ctx){
        if (ctx.success)
        {
            m_indexed = indexed;
            emit isIndexedChanged();
        }
    },
    //allow to specify if the task should be run on a specific thread, null (default) will run on any thread
    "ML_FOLDER_ADD_QUEUE");
```

fixes #26149