Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

In order to implement several standalone video filters (with capability
"video filter") using OpenGL filters (with capability "opengl filter"),
define an helper to delegate the work to the "opengl" video filter.

Co-authored-by: vatsin1810 <suchak@sas.upenn.edu>

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

 using Qt parenting auto deletion leads to using the window in
 InterfaceWindowHandler destructor while it's partially destroyed

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This is what it's always used with. No need for lossy conversions to int.

was related to replaced API
refs #26012

This will provide better quality when expanding the size compared to the
initial size.

It's lighter and faster.

Marvin Scholz authored 3 years ago and Steve Lhomme committed 3 years ago

This makes it consistent with all the other uses of such defines in
the source code, which are tested for their existence rather than the
actual value.

If we build with mingw64 8+ we didn't generate it, and we still won't.
Otherwise mingw64 was already extracted for winpthread, so we just use the
header from there.

Marvin Scholz authored 3 years ago and Steve Lhomme committed 3 years ago

This function is not used at all anymore in the VLC codebase
so the check serves no purpose.

Marvin Scholz authored 3 years ago and Steve Lhomme committed 3 years ago

This function is not used at all anymore in the VLC codebase
so the check serves no purpose.

Marvin Scholz authored 3 years ago and Steve Lhomme committed 3 years ago

This function is not used at all anymore in the VLC codebase
so the check serves no purpose.

Marvin Scholz authored 3 years ago and Steve Lhomme committed 3 years ago

pread is used regardless of this check in the code, so checking it
serves no purpose

  this provides the same functionnality as save/restoreWidgetPosition but acts
  on Window directly, it mimics qt implementation of widget state serialisation

  this has no use anymore, menus are either created for QML or as standalone
  when qt is a dialog provider

  this allows to have modal native window when the main window is a QQuickWindow

  fixes: #25865

  fixes: #25865

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

When avcodec is found, it does not really add much value to check for
the avcodec header. avutil is required by it, so checking for that
is not needed either.

For avformat, avcodec is required, therefore checking for
avcodec and avutil headers is not needed there either.

Conditionally including those in avcommon_compat.h does not
seem needed at all, as it won't compile without these headers
anyway.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The avutil version is always higher or equal to 55 with the
versions of ffmpeg/libav required in configure.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This file requires aribb24, so without the includes it does not
compile at all, making the conditional includes here useless.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The related meson issue was fixed in meson 0.54.0 and extras/tools now
requires meson 0.54.2 or higehr, else it builds it anyway. So there is
no need to force it anymore here.

Fix in meson upstream in 49ae886620c5d140efbbe177ff0565ba100309f2