fixes: #25865

  fixes: #25865

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

When avcodec is found, it does not really add much value to check for
the avcodec header. avutil is required by it, so checking for that
is not needed either.

For avformat, avcodec is required, therefore checking for
avcodec and avutil headers is not needed there either.

Conditionally including those in avcommon_compat.h does not
seem needed at all, as it won't compile without these headers
anyway.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The avutil version is always higher or equal to 55 with the
versions of ffmpeg/libav required in configure.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This file requires aribb24, so without the includes it does not
compile at all, making the conditional includes here useless.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The related meson issue was fixed in meson 0.54.0 and extras/tools now
requires meson 0.54.2 or higehr, else it builds it anyway. So there is
no need to force it anymore here.

Fix in meson upstream in 49ae886620c5d140efbbe177ff0565ba100309f2

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

 - documented parameters need to appear in the prototype.
 - offset was probably a leftover from copy-paste.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

 - functions returning void with a \return is incorrect.
 - missing documented parameter names in the prototypes.
 - copy-paste leftover for vlc_playlist_SetPlaybackOrder.
 - vlc_playlist_Preparse doesn't need a libvlc instance.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

 - missing documented parameter names.
 - void functions with a \return parameter is incorrect.
 - non-matching parameter names and documented parameters.
 - player_rate doesn't exist in vlc_player_timer_point_Interpolate.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The callbacks and opaque seem to have been replaced by a whole owner
object.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

If the parameter is documented in the prototype, it should be specified
in the prototype and should not be left out.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

 - \param is used to declare a parameter, so \p should be used to
   reference them.
 - `type` parameter didn't exist.
 - `opaque` parameter was named `data`
 - \return for void functions is not correct. Moving the notice to a
   \bug reference.
 - \see used instead of \ref.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Doxygen and other clients will complain.

KO Myung-Hun authored 4 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This fixes subtitle texts are not shown correctly on OS/2.

Freetype module expects UCS-4 string. However, OS/2 iconv() does not
support UCS-4 encoding, so UCS-2 encoding is used on OS/2. Because of
this mis-match, subtitle texts on OS/2 are mis-interpreted. As a result,
subtitle texts are not shown correctly.

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

the cpu SIMD selection code removed here dates from a time when vlc had
options for disabling use of select SIMD variants, from before postproc
added cpu auto-detection ([1]), and from before postproc seems to have
added SSE2 ([2] and [3]).

we are purging MMX/MMXEXT from vlc v4.0-dev, and thus have an interest in
removing the corresponding MMX/MMXEXT bits here. rather than just removing
those lines, alongside adding an entry for SSE2 though, i have instead
chosen to convert the code to use auto-detection, which avoids having to
keep the block of code explicitly enabling implementations in sync with the
set of implementations available.

note, the version of postproc in contribs is very old, pre-dating the
SSE2 and CPU feature auto-detection enhancements. accordingly i have had to
ensure that we define `PP_CPU_CAPS_AUTO` ourselves when not found, as had
been done for `PP_CPU_CAPS_ALTIVEC`. effectively, for users like myself on
linux with a new enough version, the auto-detection will work correctly and
now make use of SSE2, which we were ignoring before; while where the
contrib package is used, its use will fall back to the C implementation
until such time that the contrib gets updated.

[1]: https://github.com/FFmpeg/FFmpeg/commit/59d686f100863d00b8f171dd891e893c2bfd951e
[2]: https://github.com/FFmpeg/FFmpeg/commit/4e264d1c79cfae8c3e05aacf77e350ed1b6d7e4b
[3]: https://github.com/FFmpeg/FFmpeg/commit/f48cddfe4cf04e2d6e802d12e973301ff5a1a9a8