Steve Lhomme authored 1 year ago and Thomas Guillem committed 1 year ago

As contribs keep being updated with newer versions of the language, we need to
support a more modern version of C++ going forward.

Setting -std=c++17 should not break existing contribs that are built with C++11 or C++14.
In fact we already support the mix of versions between 11 and 14 without problem.
Modern C++ compilers are designed to take care of this [1].
When switching to a new C++ version there might however be some slight differences on how the
code is interpreted. These differences [2] might trigger some build errors for removed parts.

[1] https://stackoverflow.com/questions/46746878/is-it-safe-to-link-c17-c14-and-c11-objects
[2] https://www.open-std.org/JTC1/SC22/WG21/docs/papers/2018/p0636r3.html

Pierre Lamot authored 1 year ago and Steve Lhomme committed 1 year ago

Qt6 raise a warning when passing an initialization value to a non-existant
property in a component. At some point we may refactor theses view to inherit
from a common base. for now we just define the property where required

Pierre Lamot authored 1 year ago and Steve Lhomme committed 1 year ago

path not starting by qrc:/// are not resolved correctly by
QQmlFile::urlToLocalFileOrQrc in Qt6

Pierre Lamot authored 1 year ago and Steve Lhomme committed 1 year ago

Calling C++ methods with 'this' objects different from the one they were
retrieved from is broken, due to historical reasons. The original object is used
as 'this' object. You can allow the given 'this' object to be used by setting
'pragma NativeMethodBehavior: AcceptThisObject'

Pierre Lamot authored 1 year ago and Steve Lhomme committed 1 year ago

Calling C++ methods with 'this' objects different from the one they were
retrieved from is broken, due to historical reasons. The original object is used
as 'this' object. You can allow the given 'this' object to be used by setting
'pragma NativeMethodBehavior: AcceptThisObject'

François Cartegnie authored 1 year ago and Steve Lhomme committed 1 year ago

useless as the startcode always lies in first bytes
if there's no PUSI violation

Fatih Uzunoğlu authored 1 year ago and Steve Lhomme committed 1 year ago

cmake 3.21.0 is required to build Qt 6.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Fix an allocator mismatch for HTTP resources. They are destroyed via a
free call in the C API via the `vlc_http_res_destroy` function.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Returning `VLC_TICK_INVALID` will actually pass as a success as it is
currently defined as 0.

Jonas Dittrich authored 1 year ago and Kakadus committed 1 year ago

The fourcc and length needs to be skipped on empty strd chunks, otherwise the stream is not advanced, resulting in a hang.

Tristan Matthews authored 1 year ago and Steve Lhomme committed 1 year ago

2024-01-17 v3.8.1
  This release includes several bug fixes. This release is ABI
  compatible with the last release. See
  https://aomedia.googlesource.com/aom/+log/v3.8.0..v3.8.1 for all the
  commits in this release.

  - Bug Fixes
    * aomedia:3520: get_cubic_kernel_dbl: Assertion `0 <= x && x < 1'
      failed.
    * aomedia:3526: alloc_compressor_data() is called during every
      aom_codec_control() call on the encoder.
    * aomedia:3527: aom/av1/encoder/mcomp.c:1810: av1_full_pixel_search:
      Assertion `ms_params->ms_buffers.ref->width ==
      ms_params->ms_buffers.src->width' failed.
    * aomedia:3534: libaom encoder crashed by AOM_USAGE_ALL_INTRA and
      AOM_EFLAG_NO_REF_LAST flags.
    * b/310455204: Recreate workers if necessary.
    * b/310548198: Update frame size in actual encoding.
    * b/314858909: Do not use adaptive error estimate.
    * Fix a hang of cmake on arm64 macOS with cmake 3.27.0 or later.

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

We're supposed to unlock after the error, given that the lock is just
above.

Regression from 7dcc370d.

So we can bump the requirement without building cmake for every build.

Was incorrectly setting start=stop on ephemer SPU

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

Equivalent to commit d8e941f5 for
meson.build.

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

The test has been merged into autotools[^1] but wasn't ported to meson.

[^1]: 4ddc948f