Regression from d23b4527

refs #22524

Refs #22524

As we will save the playback states in the media library from the
player, we need to ensure the media library is still available when
doing so.
Since the last save can occur while destroying the player and it's
associated input, we need the media library to be destroyed after the
player, and therefor the playlist.

The input already takes care of it by probing the demux in
UpdateTitleSeekpointFromDemux

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

vlc.player.add_subtitle accepts a second parameter autoselect which
default to fals.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

Issued from c9e27177 refactor.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Erwan Tulou authored 5 years ago and Thomas Guillem committed 5 years ago

At https://doc.qt.io/qt-5/qabstractitemmodel.html#dataChanged

, it reads:
"This signal is emitted whenever the data in an existing item changes."

My understanding is that emitting dataChanged() is limited to the update of
an existing item. Neither insertion nor deletion of an item have to emit
this signal.

Furthermore, in the case of deletion, this may lead to the following error:

ASSERT failure in QList<T>::operator[]: "index out of range", file /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h, line 549

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Qt setup a vlc_player_timer with a minimal period of 500ms. To propagate these
point to the UI, 2 QTimer are used.

 - A time QTimer: it will ask the player when the next second of the media will
   be reached in order to wait accordinly and update the time at the right
   time.

 - A position QTimer: it will update regularly the position, depending on the
   length and rate of the media. Maybe it should also do it according to the
   slider width too.

Before that, the input time was used, it could be delayed by 300ms to 2seconds
depending on your output buffer size (generally, led by audio module buffer
size). Furthermore, the input time was only updated every 250ms. This could
lead to a delay of (250 - 1) ms before updating the right second (and not
taking the output delay into account).

(faster tests)

In order to be able to test the master clock. For now, the master clock is only
driven by the audio output with a valid time_get.

This module doesn't have any latency, the first returned delay is 0.

RFC: Maybe it should belong to a test audio output.

Any interface or control modules could request a timer from the player. This
player timer is like the player event listener except that:

 - It is only used to receive time update points0:

 - The timer is not locked by the player lock. Indeed the player lock can be
   too "slow" (it can be recursive, it is used by the playlist, and is it held
   when sending all events). So it's not a good idea to hold this lock for
   every frame/sample updates.

 - The minimum delay between each updates can be configured: it avoids to flood
   the UI when playing a media file with very high fps or very low audio sample
   size.

The time updated is the output time, unlike the on_position_changed event that
use the input time. It can fixes a very big delay between the UI time widgets
and the outputted content (depending on the audio output module, this delay
could be close to 2seconds).

The vlc_player_timer_point struct is used by timer update callbacks. This
public struct hold all the informations to interpolate a time at a given date.
It could be done with the vlc_player_timer_point_Interpolate() helper. That
way, it is now possible to get the last player time without holding any locks.

There are two timer types:

 - vlc_player_AddTimer(): update are sent only when a frame or a sample is outputted. Users of
   this timer should take into account that the delay between each updates is
   not regular and can be up to 1seconds (depending of the input). In that
   case, they should use their own timer (from their mainloop) and use
   vlc_player_timer_point_Interpolate() to get the last time.

 - vlc_player_AddSmpteTimer(): send a SMPTE timecode each time a frame is
   rendered. This timer use a different callback struct and data struct:
   vlc_player_timer_smpte_timecode. It's not possible to interpolate it, the UI
   should update its widgets once it receive the new timecode update. This
   SMPTE timer handle NTSC 29.97 and 59.94 drop frames and is frame accurate.

input_PushControl() returns an error when the control array is full. We could
fix it by using a dynamic array but we will still have to check for the
allocation in that case.

In order to get the pause and play date from the player.