RTP audio/MPA format is mostly but not quite packetised.
Do the strictly needful in the payload format handler.

Invert the checks for (in)valid frame headers to bail out early,
reindent and remove logically dead code.

All values are between 0 and 65535 here, so they fit in unsigned short.

This moves the function to a header for reuse.
No functional changes.

VLC does not handle negative timestamps so far. So the initial NTP
reference timestamp should be positive enough that the extrapolated
PTS will not end up negative when the RTP packet timestamp is lower
than the reference RTP timestamp. In that case the PTS is lower than
the NTP reference.

While 2^62 was a very safe value in that respect, it lead to integer
overflows in the clock and in time base conversion code. To avoid this,
we pick a default NTP reference value equal to the closest power of two
of the NTP time of this changeset: 2^52 is in 2042 CE, 2^51 in 1971 CE.

Hannes Domani authored 4 years ago and Jean-Baptiste Kempf committed 3 years ago

Due to a bug in the directory, some streams lack a listen URL.

Fix #25309

François Cartegnie authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

auto assigned ID can't be compared to auto assignment request value

The lock is no longer taken for reading ever, so it is equivalent to a
mutex. In fact, the lock is only needed to prevent concurrent writes
to the same config_item_t::value.

This makes config_GetStr() lock-less.

No functional changes.

This factors the common code to set a string variable value. This also
makes the handling of the empty string consistent across all paths.

...instead of read-write lock. This provides for lock-free wait-free
log output, which is orders of magnitude more frequent than switching
log backend.

See built-in Doxygen for details.

Niklas Haas authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

As of libplacebo 80a07bf48, the color map operation can end up as a
true no-op. In this case, this results in a blank shader with no
signature. Don't crash on this case, but simply omit the call to the
libplacebo shader entirely.

Fixes #26326

Alexandre Janniaux authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

vlc_placebo_PlaneData is expecting an array of four elements. Not
complying to this results in the following warning, even if the code is
not making use of the other planes.

../../modules/video_output/libplacebo/display.c:369:18: warning: ‘vlc_placebo_PlaneData’ accessing 480 bytes in a region of size 120 [-Wstringop-overflow=]
  369 |             if (!vlc_placebo_PlaneData(r->p_picture, &subdata, NULL))
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This adds standard support for RTP Vorbis
and draft support for RTP Theora.

Hugo Beauzée-Luyssen authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

contains() was added in 1.10 and item() is supported since 1.9

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

based on user feedback

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The CodecDelay needs to be substracted from the PTS of all frames of that
track. That may result in negative DTS, PTS and PCR which is not well handled.
So we just shift all timestamps based on the biggest CodecDelay so all
timestamps are always positive.

This is in line with how libavformat reports the timestamps on frames from a
track with a CodecDelay.

This is done per segment as other segments may use a different CodecDelay
per track.

Fixes #25129

This makes config_GetInt() and config_GetFloat() completely lock-less.

The non-atomic copies are left for backward compatibility.

This was only there to handle the dirty flag atomically with the actual
saving of the configuration file.