Alaric Senat authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

These functions are inline and will be removed by the compiler anyway if
unused. The #if guards add unecessary compexity.

Alaric Senat authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

"Release" usually imply that the object is refcounted in recents VLC
naming conventions. "Delete" or "Destroy" is more common and less
misleading for non-shared objects such as `vlc_fifo_t`.

Hugo Beauzée-Luyssen authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The list of changes can be found at
https://code.videolan.org/videolan/medialibrary/-/milestones/13

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

don't capture mouse clicks in hoverhandler of title col delegate

fixup 10e096a3

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

don't capture mouse clicks in hoverhandler of default col delegate

fixup e2440608

Benjamin Arnaud authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Co-authored-by: Pierre Lamot <pierre@videolabs.io>

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It's already included by config.h

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The commit ca7d2ea4 introduced an xyzw
swizzle, whereas the previous code was using an rgba swizzle. No other
location used the xyzw swizzle for texture so unify and use rgba
everywhere.

Different version from aa5bec3b

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

GL_LUMINANCE_ALPHA textures should be sampled through r and a swizzle
since it has a `(L,L,L,A)` layout.

This reverts commit 05f29287.

Fixes #26767
Reintroduce #26735

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The swizzle of the texture should be different between
GL_LUMINANCE_ALPHA textures and GL_RG textures.

This reverts commit aa5bec3b.

Refs #26767

Felix Paul Kühne authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

This adds an additional info line to match the IPv6 implementation.

Prince Gupta authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

fixup 4e2f8238

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

inconsistent with that used in `coverartarchive_make_releasegroup_arturl()`.

i believe that with-dash is likely the correct form, since firstly, that
function is actually used unlike this one, and this function was also
fundamentally broken before the previous commit. also secondly, the info
at [1] seems to indicate that with-dash is correct.

[1]: https://github.com/Borewit/musicbrainz-api

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

and fix leak with the corrected logic.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

volume is valid only if !bitexact.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It's really weird to call functions with a NULL pointer...

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Relaxed because we don't need synchronisation with other variables.

gain_factor and output_factor are write from different threads, so a
sequentially consistent ordering won't help.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

 - output_factor is read from aout_volume_Amplify(), called from the
input/decoder.c DecoderThread.

 - output_factor is written from aout_volume_SetVolume(). It is either
   called  from the same thread via the start cb (OK in that case) or
   from any threads via the volume_set cb.