Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Per the comment in the header this is no longer needed once we stop
targetting 10.7; we are now targetting 10.10

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 1 month ago and Steve Lhomme committed 1 month ago

macosx: Access parent group type via groupDescriptor property rather than via jany climbing of view tree

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

The restrained size is in source unscaled coordinates
when apply_scale is not set.
We need to unscale the output dimensions to check if it fits inside in that case.

Fixes positioning of SPU's when the window is smaller than the source.

Plus rename SpuAreaFitInside() to SpuAreaMoveInside() as it's not fitting, ie
stretching anything, just moving the subpicture (and probably shouldn't for
absolute placement anyway).

From !6750 (comment 470781)

> the C standard doesn't guarantee that you can cast a function pointer into a
> void* it only guarantees you that you can cast a function pointer to another
> function pointer.

It requires an extension C17 N2176 J.5.7:

> A pointer to an object or to void may be cast to a pointer to a function,
> allowing data to be invoked as a function (6.5.4).

> A pointer to a function may be cast to a pointer to an object or to void,
> allowing a function to be inspected or modified (for example, by a debugger) (6.5.4)

The Direct3D9 code is enabled for non-UWP targets and all Windows targets
have this DLL (since Vista).
DXVAHD_CreateDevice is available since Windows 7 [^1].
If for some reason the DLL is not there, the plugin won't be loaded
and it will rightfully be skipped.

[^1]: https://learn.microsoft.com/en-us/windows/win32/api/dxvahd/nf-dxvahd-dxvahd_createdevice

The Direct3D9 code is enabled for non-UWP targets and all Windows targets
have this DLL (since Vista).
DXVAHD_CreateDevice is available since Windows 7 [^1].
If for some reason the DLL is not there, the plugin won't be loaded
and it will rightfully be skipped.

[^1]: https://learn.microsoft.com/en-us/windows/win32/api/dxvahd/nf-dxvahd-dxvahd_createdevice

The Direct3D9 code is enabled for non-UWP targets and all Windows targets
have this DLL (since Vista).
If for some reason the DLL is not there, the plugin won't be loaded
and it will rightfully be skipped.

Direct3DCreate9Ex() is available since Vista [^1]:

> Direct3DCreate9Ex is supported only in Windows Vista, Windows Server 2008, and Windows 7. Earlier versions of the D3D9.dll library do not include Direct3D9Ex and Direct3DCreate9Ex.

We fallback to Direct3DCreate9() just in case it fails for maximum compatibility.

[^1]: https://learn.microsoft.com/en-us/windows/win32/api/d3d9/nf-d3d9-direct3dcreate9ex#remarks

The DXVA2 code is enabled for non-UWP targets and all Windows targets
have this DLL (since Vista).
If for some reason the DLL is not there, the plugin won't be loaded
and it will rightfully be skipped.

The DXVA2 code is enabled for non-UWP targets and all Windows targets
have this DLL (since Vista).
If for some reason the DLL is not there, the plugin won't be loaded
and it will rightfully be skipped.

It is found in Windows 7 with KB2533623 [^1].
This KB is required on VLC 4 since 64707300.

[^1]: https://learn.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-setdefaultdlldirectories#requirements

This will avoid errors like fbbd68f8.

The DMO code is enabled for non-UWP targets and all Windows targets
have this DLL (since Vista).
msdmo.dll with DMOEnum() is available in vanilla Windows 7.

If for some reason the DLL is not there, the plugin won't be loaded
and it will rightfully be skipped.

Fatih Uzunoğlu authored 2 months ago and Steve Lhomme committed 1 month ago

This fixes delegate can not be loaded issue with Qt 6.2.

Fatih Uzunoğlu authored 2 months ago and Steve Lhomme committed 1 month ago

Functioning of double clicking list view delegate is broken due to "Error:
Insufficient arguments".

At the same time, `currentIndex` should be used instead of the first selected
item when view is requested.

Fatih Uzunoğlu authored 2 months ago and Steve Lhomme committed 1 month ago

It is not clear why such signal exists, it seems that it is
supposed to be a function instead.

Regardless, having such signal is not meaningful because there
is already `currentIndex` which is synchronized with the shown
artist. This synchronization is satisfied by the change handler.

The change handler already needs to adjust the artist id (for
synchronization), making `showArtist()` meaningless.

Currently clicking a delegate does not change the current index.
Views should change the current index when clicking on delegate.

Fatih Uzunoğlu authored 2 months ago and Steve Lhomme committed 1 month ago

It does not make sense to adjust selection within `resetFocus()`. This
causes the initial selection to be the first item while normally there
should not be a selection initially.

Fatih Uzunoğlu authored 3 months ago and Steve Lhomme committed 1 month ago

Here, Qt wants to create a layer because when source is `QQuickImage`,
`QGfxSourceProxy(ME)` checks its fill mode and source size.

In this case, we need to tell Qt that we don't need a layer here, as
we are doing the mapping as we want but Qt currently does not offer
a way to tell that and simply tries to decide itself: "If needed,
MultiEffect will internally generate a ShaderEffectSource as the
texture source"

Using the static texture for the blur source has also the advantage
of applying blur only once because the source would not get updated
constantly due to size change. With clipping, we can simply adjust
the viewport without needing to update the blur.

Unfortunately we can not do this with older Qt versions, because if
the source image changes fill mode from stretch or to stretch where
it is fed to a blur effect, the effect either causes crash (layering
needed to not needed, so Tile -> Stretch) or does not work (layering
not needed to needed, so Stretch -> Tile).

Thomas Guillem authored 3 months ago and Steve Lhomme committed 1 month ago

Switch to cmake from this commit since the previous smb2 version has not a
fully functional cmake configuration.

Thomas Guillem authored 3 months ago and Steve Lhomme committed 1 month ago

To prepare for the next commit.

Thomas Guillem authored 3 months ago and Steve Lhomme committed 1 month ago

To avoid conflicts with smb2.h

Similar to ca1e1569.
GetCurrentThreadStackLimits is also available in UWP.

We don't need to create an object just to load the DLL shaders.

It redirects to the d3dcompiler_47.dll in mingw-w64 and in the Windows
SDK that's the only variant there is. This is also how D3DCompile()
is supposed to be used [^1].

The DLL is available in Windows 7 with Platform Update [^2].
No version of d3dcompiler_XXX.dll is available in vanilla Windows 7
which doesn't have Direct3D11 anyway.

[^1]: https://learn.microsoft.com/en-us/windows/win32/api/d3dcompiler/nf-d3dcompiler-d3dcompile
[^2]: https://learn.microsoft.com/en-us/windows/win32/direct3darticles/platform-update-for-windows-7

We don't use it anymore.