The fun part has been supported by the rotation filter for 7 years.

The serious part should be handled by the GUI and/or the video window,
under control of the operating system or windowing system.

Unlike the other info boxes, this does not seem to serve any useful
purpose for the (rare) users of the NCurses interface.

This corresponds to the previous changeset. In principles, this could
now also work for other inputs than V4L2.

This fixes two long standing deprecated warnings.

This is not exactly great, and it (still) will not work properly if
there are more than one demux with controls on a single input.

But at least it does not rely on racy walking of the objects tree
and matching object name, nor racy usage vlc_object_t public members.

Returning NULL is not an error, a lot of filters do return NULL waiting for
more data.

Victorien Le Couviour--Tuffet authored 6 years ago and Thomas Guillem committed 6 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Victorien Le Couviour--Tuffet authored 6 years ago and Thomas Guillem committed 6 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Fixes #21993

Regression from 3c9b5fe7

Fixes #21990

Regression from f58bd455

This has been deprecated for over 7 years, and broken for yet longer.

avcodec uses signed dimensions for no obvious reasons.
Not much to do about it on VLC side.

This internally replaces the objects tree with a flat list. This makes
browsing from parent to children slower, which is a bad idea and only
vlc_object_find_name() relies on.

It is far more common to go from child to parent, which is unaffected
and remains O(1). Although it is also not typically a good idea.

... than for list to iterate.

This should be removed altogether, when custom input controls are
cleaned up.

This removes the global name lock.

As of now, only "v4l2" is ever still used.

The tree lock is only necessary for finding an object by name.
Finding an object by name is only necessary anymore for V4L2 input
controls.

So optimize this for simplicity and memory use rather than performance.

Unfortunately, plane_t.i_pitch is (still) signed.

This is the same as 11874bc5, but
within the (combined) image demuxer. Alternatively, we would have to
write one submodule and callback for each image format.

memcmp() over an invalid pointer is undefined. If the marker size is
larger than zero, we can assume that the peek pointer is valid, after
vlc_stream_Peek() succeeds.

The assertion makes sense insofar as a marker size of zero would
essentially match every possible input, and should never be usedn.