1. Avoid dynamic memory allocation for small samples_per_chunk
(less or equal to 2 sample per chunk). Depends on the test file
and OS, the time taking by MP4_TrackClean can be reduced from a
few seconds to dozens of milliseconds.

2. Merge some allocation to single memory chunk. For mp4 files
with a lot of chunks, the time taking by MP4_TrackClean can be
reduced by half.

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

The config "advanced" flag was unused and has been removed by
6a7a137f.

It has been removed from many add_*() macros, but not all. Remove it
from the remaining macros.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The UIKit functions must be called from the main thread, whereas the
functions from the inhibiter can be called from the vout thread. It
didn't seem to have any consequence on iPad, or the testing I did was
not triggering the crash, but it's leading to a crash on tvOS when
running with VLCKit.

Brad Smith authored 3 years ago and Thomas Guillem committed 3 years ago

Set volume/mute function pointers when handle is freed, to ensure
sio_setvol() is not called on a freed handle. Fixes crashes when volume
is adjusted while playback is stopped.

Fixes #25796

Refs #25694

Move it to DecoderWaitUnblock(). It is now possible to do this
simplification because of the previous commit: DecoderWaitUnblock() is
now called only when has_data should be changed to true.

Video decoders always display their first picture, in a forced state,
bypassing the DecoderWaitUnblock() check. Re-arrange the code to make it
more obvious.

We generally see cond_wait surrounded by a while loop.

It is not needed if the picture is forced or if we don't care about
frame lateness (frame_next).

No functional changes.

Not needed anymore since this variable is always locked by the owner->lock.

In order to merge the usage of the same lock and avoid locking it twice
in a row. This new status struct be used to get the status of sub ES
tracks created by decoder modules.

Prince Gupta authored 3 years ago and Pierre Lamot committed 3 years ago

parentId property was removed in cd89555e

  both the intf and the vout window reference the qt interface structure
  it will only be released once not used by both modules, this way the windows
  continues to exists if the interface is closed before.

  When the interface module is released before the vout window, the qml view and
  the associated resources are unloaded from the compositor.

  fix: #25600

  this allows to unload the GUI part of the interface without destroying the
  windows that may still be used by the vout window part.

  the variable was no longer initialized properly as it was stored
  in a "C" structure and there was no reason to store this variable in
  the module

  this will allow to unload the interface module without unloading Qt in a
  further patch.

  the new structure is still a vlc object as we use it notably for logging
  capacity and to interact with vlc variables

  This is a preparatory commit

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It's finally time to use RAVU/FSRCNN(X)/NNEDI3/Anime4K in VLC.

Currently limited to only one shader, which isn't a huge limitation
seeing as you can just `cat` together as many shaders as you want to use
into one big file. But patches welcome(tm).

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Unfortunately the UI for loading these is a bit clunky as they're hidden
behind so many layers of menu and advanced options, plus the fact that
the new LUTs still only get applied on vout reinit.

But it's still a feature that a lot of users have requested heavily, so
supporting them at all is a good thing. The implementation is rather
straightforward even though the amount of #ifdef's are really getting on
my nerves.

Can somebody just time travel me into a future universe in which I can
make libplacebo v4 the minimum dependency?

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Cosmetic. Side note: I really, *really* hope this commit title breaks
something, somewhere.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This is redundant with the minimum version requirement being 1.7.

I sure can't wait until the next bump up to 1.29.0. All these ifdefs
keep reminding me of my failure to design a good API on my first try.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

`pl->ops->close` destroys the GPU instance, after which the swapchain is
undefined. Fix it by moving the swapchain destruction to `ops->close`
itself, where it can be done in the correct order.

(This also fixes a bug where, technically, the opengl instance attempted
destroying the swapchain while the context was not current on the
thread)

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Recent versions of libplacebo use `pl_frame.crop` instead of
`pl_render_target.dst_rect`, for which the latter is now merely a
fallback.

Unfortunately, `pl_render_target_from_swapchain` ends up setting the
former field to values based on the swapchain dimensions, so the values
we set in `dst_rect` accidentally ended up ignored. In retrospect, this
was caused by the upstream decision to make the new field override the
old field if both are present, and having that logic the other way
around would also have avoided this bug. Bite the bullet and make it
conditional on the PL_API_VER.

All that said - merely fixing this bug, however, exposed serious
shortcomings in the video placement logic, in particular the lack of
proper flipping support for OpenGL. Fix it by rewriting the video
placement logic completely, based on the observation that
`vout_display_PlacePicture` is a relatively cheap function to call.
There's no need to awkwardly cache it inside `sys`.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This field was left-over from an early API design, and never used for
anything in libplacebo. Recent versions have since deprecated it.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

New upstream feature. Simply needs to be exposed in the UI.