Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This reverts commit 21d696e5.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

-pthread does not work in with CXX-tagged libtool invocation.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

medialibrary uses atomics which may require libatomic depending on the
ABI. This is currently the case on Linux RISC-V. In principles, it
should be pulled as needed by `-pthread` which should be in LDFLAGS.
However:
1) The VLC build system passes `-pthread` in LIBADD instead of LDFLAGS.
2) GNU/libtool discards `-pthread` for CXX-tagged binaries.

This is essentially the same problem as with libupnp lacking
`-lpthread`. In this particular case, medialibrary.pc forces `-lpthread`
explicitly but lacks `-latomic`.

Fixes #26521.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Do not write env variable values that are not set to the crossfile
as empty strings as there is a difference between no value and the
empty string for some variables.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Write pkg_config_libdir to the correct crossfile section, should
fix the build after 74060949.

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

windowHandle() may return null if the current widget is not the window widget

fix: #26578

Prince Gupta authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

on window resize, it seems that qt event loop is overwhelmed with resize
events, making timer event of requestUpdate called very late, that
causes delays in rendering

manually call render to avoid out of sync window painting
ref #25572

Prince Gupta authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

instead of manually tracking variables, use a temp variable for
debouncing, may fix random breaking of layout

Alexandre Janniaux authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

Set the default packetizer to any so that every packetizer are probed,
instead of NULL which is now considered an error.

Regression from 2480a515.

Fixes #26566, #26576

Lyndon Brown authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

The previous commit made use of compound literals. MSVC was identified
as not yet having support for compound literals in C++ though, which is
considered a blocking problem to their use. This work around was
suggested by Alexandre Janniaux.

Lyndon Brown authored 5 years ago and Rémi Denis-Courmont committed 3 years ago

I.e. check the type of the values provided, rather than just blindly
casting, and thus allow mistakes to get caught with compilation errors.

I once lost some hours tracking down the cause of a crash that this type
strictness would have prevented.

Note, now that `change_string_list()` and `change_integer_list()` use type
strictness for the value and label arrays to help make sure they're the
right types, we can more safely make use of `ARRAY_SIZE()` to more cleanly
get the length.

`set_callback[s]()` is excluded from this for obvious reasons.

I've taken the opportunity to ditch remaining use of Hungarian notation
and to fix a param name that should be singular rather than plural
(psz_caps on `add_module[_list]()`.

Re-implemented using compound literals upon excellent suggestion by
Alexandre Janniaux.

vlc_stream_NewURL() can spawn stream filters which may alter the content
or even the nature of the stream, which is not suitable here.

vlc_access_NewMRL() would avoid loading stream filters at all. But it
would also skip testing the cache filter, thus missing much of the point
of the test case.

So use a reproducible pseudorandom input using a constant seed, which
is known not to trigger any stream filter.

Fixes #26569.

libvlc_audio_output_set() had no practical effects as the audio output
was consistently created before the application had the opportunity to
select a non-default module. This fixes it.

An alternative would be to remove the function entirely. Exposing
module names to LibVLC applications is bad design.

Historically this function would set the device for a specified audio
output module. This required the application to somehow "know" what
audio output module it wanted to use, which is very suboptimal for
forward compatibility and portability.

Worse yet, this design failed outright in VLC 2.2 with the addition of
MMDevice and PulseAudio. This lead to the convention of leaving the
module parameter NULL to change the device of the currently active
audio output.

As with the removal of libvlc_audio_output_device_list_get(), it seems
saner to simply remove the old broken semantics.

This function does not work with MMDevice and PulseAudio, and does not
support hot-plug. To enumerate devices, the newer function
libvlc_audio_output_device_enum() ought to be used, which also works
with MMDevice and PulseAudio, and track audio device events.

No amount of documentational warnings will save developers from using
this broken function. It is better to remove it now that there is the
opportunity to do so in the form of the LibVLC 4.0 binary compatibility
break.

Brad Smith authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

Fixes #26573

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Brad Smith authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

Fixes #26572

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

This applies the user-requested transform to the video format, rather
than the pictures. Doing this serves multiple purposes:
 - the filter chain format can be computed correctly (notably the SAR),
 - the transform filter can process any format, including opaque ones.

Instead of creating a sub-chain with a singular hard-coded transform
filter instance, the chain video converter treats mismatched video
format orientations normally as other mismatched parameters.

In practice, this will trigger the new orientation video converter
instead of the transform video filter, and the result will be
essentially the same... when using non-opaque picture formats.

Unlike transform, this checks the video format, not some configuration
parameters. Thus a video format can undergo reorientation directly,
without having the chain video converter create a dummy chain for it.

The code is heavily based on the transform filter.

...rather than a very ad-hoc ersatz. This works because transform and
orientation are idendity-mapped.

No functional changes.

Steve Lhomme authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

Rather than the number of samples which depends directly on it.

Fixes #26565.

Disabling the window is sufficient here.