Pierre Lamot authored 10 months ago and Jean-Baptiste Kempf committed 10 months ago

qt will warn about parameter injection otherwise

Pierre Lamot authored 11 months ago and Steve Lhomme committed 11 months ago

using implicit signal handler is deprecated since Qt5.15

Fatih Uzunoğlu authored 11 months ago and Steve Lhomme committed 11 months ago

I18n module was intending to provide translation through vlc_gettext().
I'm not sure why QTranslator was not the way chosen before, because it
directly offers this and using qsTr() has the advantage of better integration.

Translation is handled in a lower abstraction level through QJSEngine
(see QJSEngine::TranslationExtension) as opposed to using custom a QML type
through QQmlEngine.

Thanks to that, the `org.videolan.vlc` module import can be eliminated
in some files.

Leon Vitanos authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

for this, we also change the height of recentVideos to it's contentHeight + bottomPadding

Leon Vitanos authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

for padding consistency, code readability and avoid code duplication

Fatih Uzunoğlu authored 1 year ago and François Cartegnie committed 1 year ago

Implicit visual parent is needed for this item
to be rendered.

Prince Gupta authored 1 year ago and Steve Lhomme committed 1 year ago

focus is passed through setCurrentItemFocus, this code will only interfere with it

Yann Lochet authored 2 years ago and Steve Lhomme committed 2 years ago

When entering MusicArtistsAlbums in small layout the focus was not set
on MusicArtist

Benjamin Arnaud authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

This enforces the fact that we're using columns instead of absolute width
to define our sizes in TableView(s) models. That way we know we always
respect the grid approach of our UI design.

Benjamin Arnaud authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

This should improve maintenability and clarity of our TableView models.
It also brings a better modularity when we have different models depending
on the current width of the application, like in MusicTrackListDisplay.

In MusicTracksDisplay we switch to a dedicated sortModel for the SortControl.

Co-authored-by: Pierre Lamot <pierre@videolabs.io>