The docs for awakeFromNib say that super has to be called when
overriding awakeFromNib, this was not done in the VLCControlsBarCommon.
It should not make any difference though in this case.

Steve Lhomme authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Steve Lhomme authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Steve Lhomme authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

This way we can't forget any when releasing it from various places.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Steve Lhomme authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

The next step is to provide a destructor so the tracks_map_t can deal with the
lifecycle of the mkv_track_t.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Steve Lhomme authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

We should not use a track that failed to be initialized properly.
The logic of the return value is inverted to be more readable. Before
it would never fail anyway.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Steve Lhomme authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

It didn't clean the es_format_t that's fully filled.
Also emit an error telling we can't handle the compression.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Steve Lhomme authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

So it's not created in a funny state.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Steve Lhomme authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

There's never anything in the p_data_init buffer.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

FS panel does not follow RTL now when it comes to time fields.
This makes sense as the slider below moves from left to right
as well.
Also set color of textfields to white to fix a problem on 10.7.

For correct RTL support, add a box around the playback controls
so that they stay left-to-right. Also fix some other constraints.
Increased the maximum height, so that the buttons can be even
bigger for TV setups.

Adds some layout constraints + priorities to fix position beneath
the popup box. Adds HUD cell subclasses and correct font so that
it looks the same as the other checkboxes.

Fix RTL for checkboxes in Open panel, video panel and audio panel.

To correctly setup RTL for checkboxes, for each checkbox
go to attributes inspector, scroll to text direction, and for
"Mirror" attributes set "in right to left interface".

Unfortunately, the default values do not work.

There are no obvious reasons to process the demux filter chain in
reverse order. All other chains are processed from upstream to
downstream.

As there was typically only zero or one filter(s), it won´t matter
much for the time being.

Just skip the chain entry. This is consistent with the behaviour of all
or almost all other configuration chains (notably stream filters).

Auto-upgrade old setting (i.e. if a user selected a RTL language
before, the settings will be autoupdated and VLC will be
restarted). Restart will not happen for the most common case
(auto language).

Enable RTL interface if RTL language was explicitly selected in
preferences.

refs #18612

Victorien Le Couviour--Tuffet authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

VideoToolbox already handles it.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Victorien Le Couviour--Tuffet authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

The GL shader already does this job.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Victorien Le Couviour--Tuffet authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

The GL shader already does this job.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Victorien Le Couviour--Tuffet authored 7 years ago and Jean-Baptiste Kempf committed 7 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>