Move the breakpad initialization right to the start of the program
and do not initialize breakpad if the VLC_DISABLE_BREAKPAD env variable
is set.

Simplify the patches (that have been sent upstream and pass CI)

Set _FILE_OFFSET_BITS as it is set in VLC as the mpg123 change ABI if it's
defined or not...

We build all contribs as static libraries.

The setting exists since CMake 3.0. For targets built with older CMake settings
the value is discarded.

It's not supported for other targets

  Deleting QmlEngine before QML root item caused context property to be released
  too early as they were attached to the QML engine

The render host time was not updated while paused.

This caused the first time_get(), after a unpause, to return a delay way too
early (corresponding to the pause time). This could happen only when the ca
render callback was not triggered between an unpause and a time_get.

This invalid delay caused the insertion of a long silence, that was not
interruptible, hence the impression of a deadlock.

Fixes #24668

A.7 3) The absence of the sync sample table indicates that all
samples are synchronization points

ref VLCKit/-/issues/367

Zhao Zhili authored 4 years ago and Thomas Guillem committed 4 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

This reverts commit 8570ea86.

Nettle is actually multilicensed as GPLv2 too, and the define was even
wrong.

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

The renderer instance is not needed anymore.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

Remove the (weak) reference to the interop from the renderer structure.

The interop is still accessed explicitly from the renderer via the
sampler structure for now.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

The fact that the sampler use internal function pointers (instead of
if-blocks for example) is an internal detail.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

Remove tex_width and tex_height parameters, as they are either unused or
accessible from the sampler itself.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

The alpha value was used to render subpictures, which are now drawn by
the subpictures renderer using its own fragment shader.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

Load uniforms related to sampler from sampler->pf_prepare_shader.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

Fetch locations related to sampler from sampler->pf_fetch_locations.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

The sampler is responsible to fetch its locations and initialize its
uniforms (including GLSL samplers).

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

This will allow to use them from several files.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

For convenience, expose the vlc_gl_t and the OpenGL virtual table in
sampler.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

Extract sampler creation and destruction to separate functions.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

This allows to use an interop instance without a renderer.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

The interop initializes its own video_format_t from the input format.

In the renderer initialization, always use this updated format. This
avoids an additional format parameter, which may be confusing.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

The projection mode can be read from the provided video format. The
intermediate renderer variable is unnecessary.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

The interop may modify its own copy of the video_format_t. These changes
must be reported to the core (by writing to the provided
video_format_t).

But as a hack, the Android interop currently flips the orientation to
avoid a vertical flip in the renderer, since it provides its own
transform matrix. This change must not be reported to the core (the core
must not flip the input), so the orientation change is reverted. A
further refactor will remove this hack later.

Meanwhile, handle the format to report to the core outside of the
renderer, so that the renderer is not involved in this hack. This paves
the way to pass only the interop to the renderer, without an additional
video_format_t instance.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

The interop instances were owned by the renderers.

To prepare for making the renderers independant of the input picture
(in particular, independant of the interop), make the vgl own the
interop instances.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 5 years ago and Alexandre Janniaux committed 4 years ago

Move the fields necessary to retrieve a picture pixel from its
coordinates.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 4 years ago and Alexandre Janniaux committed 4 years ago

Initialize GLSL version statically, so that it does not depend on
renderer->glsl_version.

This will simplify further refactors.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

The faad library isn't built for arm (see contrib/src/faad2/rules.mak),
and since eea2b426, configure actually errors out if fadd wasn't
found when it was requested to be enabled (previously this seems to have
been the intent, but it didn't actually do that).

Steve Lhomme authored 8 years ago and Steve Lhomme committed 4 years ago

It's more flexible after updates.