Not sure how to handle it.

The same way it's done in configure.ac.

Needed since bf43ffde

Claudio Cambra authored 2 years ago and Steve Lhomme committed 2 years ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Jorge Bellon authored 2 years ago and Steve Lhomme committed 2 years ago

Fixes a memory leak where elements in the linked list of events where
never released, due to the release function being always called at the
end of the traversal instead of every iteration.

This didn't seem to be causing issues like #27718 did for aom but it seems
safer than hardcoding a value.

Refs !3110

For now it is always the WebP Simple File Format (lossy):
https://developers.google.com/speed/webp/docs/riff_container#simple_file_format_lossy

Claudio Cambra authored 2 years ago and Steve Lhomme committed 2 years ago

macosx: Check value returned from KVO for effectiveAppearance change in VLCLibraryWindow, rather than checking NSUserDefaults

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 2 years ago and Steve Lhomme committed 2 years ago

macosx: Use effectiveAppearance received from KVO in VLCMediaSourceCollectionViewItem, fixing bad label text colour update

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 2 years ago and Steve Lhomme committed 2 years ago

macosx: Use effectiveAppearance received from KVO in VLCLibraryCollectionViewItem, fixing bad label text colour update

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 2 years ago and Steve Lhomme committed 2 years ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 2 years ago and Steve Lhomme committed 2 years ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 2 years ago and Steve Lhomme committed 2 years ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

The Windows SDK and mingw-w64 5+ have a clean way to group packing blocks
together. mingw-w64 generates some bogus warning (clang) when using
packing from a header, so keep it to MSVC for now.

They are defined in the Windows SDK.

It's available in mingw-w64 5+. dmo.c is a Windows only file, unlike the code
suggested.

This is the job of mingw-w64 to pick the proper variant when we set
__USE_MINGW_ANSI_STDIO. In fact when including stdio.h it undefines our defines.

It would use the proper call via mingw-w64 anyway.

The PRId64, PRIi64, etc. are properly defined since at least mingw-w64 5 which
is the minimum we support.

snprintf, vsnprintf and swprintf officially exists in the Windows SDK and in
mingw-w64 5.

It forces __USE_MINGW_ANSI_STDIO, M_PI and some functions we already have
done better in compat.

It forces __USE_MINGW_ANSI_STDIO, M_PI and some functions we already have
done better in compat.

It's not set in configure.ac either.

The mingw-w64 variant is equivalent to ours. No need to do a special case.
These are GNU functions, not C11 or POSIX functions.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

The picture is expected to be consumed, as-if it was given to an
encoder, so we also need to release it in case of error.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

Encoders are currently supposed to consume the given picture.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

Encoders are currently supposed to consume the given picture.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

Encoders are currently supposed to consume the given picture.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

Encoders are currently supposed to consume the given picture.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

If we were interrupted, we cannot notify the picture anymore so it needs
to be dropped. The behaviour is the same as if using picture_Export
here, and might not be kept in the future, but the goal is to have the
tests working and checking memory leaks before changing the behaviour,
which is also the same as the encoders currently.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

Copied from the image.c tests, but unused in the medialibrary test and
leading to memory leaks of picture.