Benjamin Arnaud authored 3 years ago and Pierre Lamot committed 3 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Benjamin Arnaud authored 4 years ago and Pierre Lamot committed 3 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Romain Vimont authored 3 years ago and Alexandre Janniaux committed 3 years ago

There were 2 problems:
 - if sys->filters could not be created, then vlc_gl_filters_Delete()
   was called, causing a segfault;
 - if the requested filters could not be loaded, then
   vlc_gl_filters_Delete() was not called, leaking sys->filters.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 3 years ago and Alexandre Janniaux committed 3 years ago

The opengl filter output size is provided by the caller.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 3 years ago and Alexandre Janniaux committed 3 years ago

In the future, we would like OpenGL and OpenGL ES2 versions of a filter
to be available without compiling it twice.

Co-authored-by: Alexandre Janniaux <ajanni@videolabs.io>
Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 3 years ago and Alexandre Janniaux committed 3 years ago

The flag filter_planes was not explicitly initialized, and non-plane
filters assume that it is set to false by default.

It still worked because the filter happens to be initialized by calloc()
in the end, but we shouldn't rely on this detail (and the other fields
are also explicitly initialized).

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

The vlc_runloop mode is designed to be executed even when an event is
being reported by the vout_window used, ie when there is a call to
CFRunLoopInMode(CFRunLoopGetMain(), CFSTR("vlc_runloop"), ..).

By adding the default mode too, it ensures it would run in the normal
CFRunLoop too.

Async tasks can still be dispatched without the "vlc_runloop" mode but
every sync task in the display must be done under this mode to prevent
deadlock from happening between the main thread and the vout_thread.

Fixes #23571

The UIView should have a well-defined size from the start.

It avoids the display to open with a size bigger than the device's
screen, which could lead to out-of-memory failures.

Report events from a different thread than the main thread, and continue
to execute the main CFRunLoop, but filter the events to only execute
the ones queued by potential display, ie. those tagged with the mode
"vlc_runloop".

The vlc_runloop mode is designed to be executed even when an event is
being reported by the vout_window used, ie. when there is a call to
CFRunLoopInMode(CFRunLoopGetMain(), CFSTR("vlc_runloop"), ..).

Clients should ensure they also tag their blocks with the default mode
too. Otherwise, they are likely to never be executed.

Async tasks can still be dispatched without the "vlc_runloop" mode but
every sync tasks in the display must be done under this mode to prevent
deadlock from happening between the main thread and the vout_thread,
typically with the following code:

    /* The main loop to run the block into */
    CFRunLoopRef runloop = CFRunLoopGetMain();

    /* The modes to execute the block in */
    CFStringRef modes_cfstrings[] = { kCFRunLoopDefaultMode, CFSTR("vlc_runloop") };
    CFArrayRef modes = CFArrayCreate(NULL, (const void **)modes_cfstrings,
            ARRAY_SIZE(modes_cfstrings), &kCFTypeArrayCallBacks);

    CFRunLoopPerformBlock(runloop, modes, ^{
        /* The block content to execute */
    });

    /* Don't forget to signal the runloop
    CFRunLoopWakeUp(runloop);
    CFRelease(modes);

To achieve a blocking/sync behaviour, clients can share a binary
semaphore between the block and the outside of the block. When using a
vlc_sem_t object, it must be qualified with __block to be modified
inside of the block.

Refs #23571

Ref #18487

Brad Smith authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

OpenBSD and other OS's use _SC_NPROCESSORS_ONLN to indicate the number
of online CPUs.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Benjamin Arnaud authored 3 years ago and Pierre Lamot committed 3 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Prince Gupta authored 3 years ago and Pierre Lamot committed 3 years ago

improves creation time of GridItem

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Prince Gupta authored 3 years ago and Pierre Lamot committed 3 years ago

removes shadows

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Prince Gupta authored 3 years ago and Pierre Lamot committed 3 years ago

provides cached selected and unselected type shadows for use in GridItem

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Prince Gupta authored 3 years ago and Pierre Lamot committed 3 years ago

can generate shadows in a Component which then can be reused at
different places, note that shadows are only created once

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Prince Gupta authored 3 years ago and Pierre Lamot committed 3 years ago

improve instantiation times for GridItem component

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 3 years ago and Pierre Lamot committed 3 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 3 years ago and Pierre Lamot committed 3 years ago

fixes qml errors that happens when the toolbar editor
gets opened.

Intends to be a temporary solution for #25643.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 3 years ago and Pierre Lamot committed 3 years ago

according to specifications, undefined can
not be assigned to qml type real

fixes part of #25601.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 3 years ago and Pierre Lamot committed 3 years ago

according to specifications, null can
not be assigned to qml type point

fixes part of #25601.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 3 years ago and Pierre Lamot committed 3 years ago

This patch fixes a component which tries to access
undefined object and tries to assign undefined to
QString.

fixes part of #25601.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 3 years ago and Pierre Lamot committed 3 years ago

fixes part of #25601.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 3 years ago and Pierre Lamot committed 3 years ago

fixes part of #25601

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

The inhibiter code is taken from VLCKit inhibiter's handling, and is
meant to replace this handling.

The pinch recognizer cannot work on tvOS, since tvOS doesn't have a
touchscreen.