Skip to content
Snippets Groups Projects
  1. Jul 30, 2021
  2. Jul 29, 2021
  3. Jul 28, 2021
  4. Jul 27, 2021
  5. Jul 25, 2021
  6. Jul 24, 2021
    • Alexandre Janniaux's avatar
      video_output: fix regression on lock · ccf7b5d9
      Alexandre Janniaux authored and François Cartegnie's avatar François Cartegnie committed
      
      The function is not locking the display_lock, so it should not unlock
      it. It's a leftover of the previous code moves, where the error path has
      not been checked correctly.
      
      Regression from 2ba73428
      
      Co-authored-by: default avatarFrançois Cartegnie <fcvlcdev@free.fr>
      ccf7b5d9
    • Romain Vimont's avatar
      vout: group chronos into anonymous structs · 59e346ce
      Romain Vimont authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      It was not obvious that sys->render or sys->static_filter were chronos.
      
      This will also allow to add more chronos properly.
      59e346ce
    • Lyndon Brown's avatar
      libmpeg2: switch SIMD selection to auto-detect mode · 00d1f50e
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      this:
       - enables SSE2 (when available at runtime), which was added 13 years ago
         ([1]) but we never enabled use of it until now.
       - removes use of the MMX/MMXEXT availability testing functions, helping
         pave the way towards our goal of purging all MMX/MMXEXT code.
       - makes the code cleaner and reduces maintenance burden.
       - allows us to pick up use of new SIMD variant additions, if any more are
         ever added (unlikely) without having to explicitly add code to enable it.
      
      as pointed out in review, the `mpeg2_init()` call makes a call to
      `mpeg2_accel()` with `MPEG2_ACCEL_DETECT` itself, so there is no need to
      make such a call ourselves, thus the `mpeg2_init()` call alone is
      sufficient. the entire code block can thus be safely removed.
      
      [1]: libmpeg2@c80d1dc2
      00d1f50e
  7. Jul 23, 2021
  8. Jul 22, 2021
    • Alexandre Janniaux's avatar
      video_output: remove wait misfire hazard margin · 832b8519
      Alexandre Janniaux authored and Romain Vimont's avatar Romain Vimont committed
      The time taken by the prepare is compound of measurements taken in
      actual preparation steps. It's made of the time needed to execute the
      static filters, the interactive filters, and the time needed for the
      display to prepare.
      
      VOUT_MWAIT_TOLERANCE is the margin of error accepted when the scheduler
      wakes up the vout_control_Pop deadline late compared to the deadline we
      choosed, or wakes up the vlc_clock_Wait late. It's supposed to move the
      deadline back wherever relevant to display a frame, to wait a little
      less that in the ideal instantaneous or real time case.
      
      It doesn't represent "time spent" so there's no need to account it in
      the duration of the prepare as a discriminator for late frames. In
      addition, it's hardcoded time not dependant on whether the media or the
      system running the video output and accounts for 1/4 of the time budget
      for rendering a frame with 60fps.
      
      Regression from a5d85a5f.
      832b8519
    • Lyndon Brown's avatar
      swscale: purge obsolete SIMD selection · 358fe9c6
      Lyndon Brown authored and François Cartegnie's avatar François Cartegnie committed
      the swscale cpu feature flags were deprecated in 2012 and removed in 2015
      ([1]) in favour of auto-detection, hence the version guard used within the
      `GetSwsCpuMask()` function.
      
      in vlc v4.0-dev we are purging MMX/MMXEXT and so have a need to remove the
      corresponding portions of the function. this alone though would leave the
      function and related code only catering to enabling altivec in the one
      special case of compiling with an old swscale version. i felt that it was
      probably better to just rip it all out.
      
      [1]: https://github.com/FFmpeg/FFmpeg/commit/9d58639e270f7612874681e0ca30fa461e2667b7
      358fe9c6
  9. Jul 21, 2021
    • Lyndon Brown's avatar
      vorbix,x264: tidy plugin variant flags · 19d74319
      Lyndon Brown authored
       - makes the code a little more readable.
       - switches to use of "plugin" rather than "module", as is more
         appropriate here.
      19d74319
    • Lyndon Brown's avatar
      chroma: tidy plugin simd variant flags · 991a7795
      Lyndon Brown authored
      ...to use short labels like `PLUGIN_PLAIN` and `PLUGIN_SSE2` rather than
      `MODULE_NAME_IS_xxx_yyy[_zzz]`. this makes the code cleaner, easier to read,
      and improves consistency. it also helps remove a source of plugin vs.
      module confusion.
      
      trying to recognise that something like `MODULE_NAME_IS_i420_yuy2` refers
      to the 'plain' variant, compared to `MODULE_NAME_IS_i420_yuy2_sse2` for the
      SSE2 variant, was problematic.
      
      the `#else // defined(MODULE_NAME_IS_xxx_yyy_sse2)` instances have been
      changed to `#elif defined(PLUGIN_SSE2)` in the i420 plugin.
      
      the flag passed to the nv12 plugin was removed (rather than replaced with
      `PLUGIN_PLAIN`) because it is unused.
      
      the i420_rgb plugin used short `SSE2` type defines. these have been changed
      to `PLUGIN_SSE2` style for consistency.
      991a7795
    • Ilkka Ollakka's avatar
      swscale: set colorspace information to swscale context · 923b582e
      Ilkka Ollakka authored and Steve Lhomme's avatar Steve Lhomme committed
      Colorspace most cases default with swscale, but it shouldn't hurt to
      define it if possible.
      923b582e
  10. Jul 20, 2021
Loading