Marvin Scholz authored 6 years ago and Rémi Denis-Courmont committed 6 years ago

This is since some time a stream filter and not a demuxer anymore,
therefore this should be named stream_filter to not cause confusion
about that.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

No need to return the same value or pass the vlc_object_t.

Not need to set it conditionally when we set it unconditionally afterwards.

Romain Vimont authored 6 years ago and Hugo Beauzée-Luyssen committed 6 years ago

On subitems changed, the old subitems (if any) must be removed.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

So we keep all the metadata we get from the decoder.

The codec is set a few lines earlier and when modified the value is also set to
the i_chroma value of the video format.

In most cases the source was already an es_format anyway.

Get rid a redundant image_ReadExt().

introduced with 3d24a401

ref #21813

refs #21814

This commit fixes passthrough playback for few devices on API 23. It was
working already for Nvidia Shield TV but not for some others (like devices
based on a Marvell chip).

Before API 23, we don't support passthrough and after we prefer to use
ENCODING_IEC61937.

Regression from 8ab3c59b

It seems that lot of developers forget to enable this option. This option
enables assert and other debug codes (like the very useful thread/mutex debug
code) that should be mandatory when you dev on VLC.

This is quite a big change: all VLC maintainers should now add
"--disable-debug" when they release a stable version of VLC.

It's always an empty video format with an 0 chroma. The format will be known
from the MIME type or the file probing.

A converter is not going to write in the source picture, it's always providing
a new picture of its output format.

The formats are always cleaned in DeleteConverter() so they need to be safe.

Technically converters probably don't handle on the fly size change but that's
a different issue.

The fmt_out would be set twice to a different value and the fmt_in is not
updated and it should probably be p_fmt_in.

es_forma_Copy will take care of everything

It has already been filled and guaranteed that it's what the converter will use

Only the video format can potentially changed as done on the next line.

The chroma shouldn't change between reuse of the converter.

To avoid confusion with real video filters

This avoids enabling HAVE_X86ASM in these configurations, fixing
compilation.

Also set proper values for WINDOWS_ARCH in these configurations.

This fixes the test for setting HAVE_X86ASM.