Skip to content
Snippets Groups Projects
  1. Sep 08, 2024
  2. Sep 07, 2024
  3. Sep 06, 2024
    • Fatih Uzunoğlu's avatar
      qt: refactor styles combobox and print the default style · ac0545c6
      Fatih Uzunoğlu authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      - Currently style handling is handled in a really fragile
        manner. The order of keys provided by `QStyleFactory`
        is expected to directly match the combobox. At the
        same time, if the style is not overridden, then there
        should be no need to save this in the settings.
      - Although the first entry is the default style, it does
        not provide what the style is. Now, the style itself is
        printed as well.
      ac0545c6
    • Fatih Uzunoğlu's avatar
      qt: fix drag and drop in `CompositorPlatform` · 1b693143
      Fatih Uzunoğlu authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      When the parent top-level window receive a drag or drop
      event, Qt does not propagate the event through the child
      windows.
      
      All handling is done in `QQuickWindow`, so if I manually
      forward the events to the quick window, drag and drop
      works as expected.
      1b693143
    • Fatih Uzunoğlu's avatar
      qt: do not wait for scene graph initialization when probing the graphics api · 3dff231e
      Fatih Uzunoğlu authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      It is documented that the static function `QQuickWindow::graphicsApi()` may
      not yield the ultimate graphics API used by the scene graph and that the way
      to get the "true, real result" is to wait until the scene graph is initialized.
      
      However, at the same time, it is said that the result would be the "graphics
      API that would be used by the scene graph if it was initialized at this point
      in time". This is what is really necessary to know here, as we don't (and
      should not) override the graphics API in compositors, rather the compositor
      should tell if it is compatible with the graphics API. If the compositor is
      not compatible (e.g. using QSGRendererInterface::OpenGL with compositor
      dcomp), then it should fail at the earliest convenience so that the application
      can try other compositors.
      
      As of Qt 6.7, Qt Quick does not implement a fallback procedure in case the
      initialization goes wrong due to the chosen graphics API that it tries a
      different graphics API. In other words, Qt Quick does not have a cross-graphics
      API fallback procedure unlike us. And the cross-graphics API fallback that
      we use gets engaged earlier, so it can be assumed with certainty that the
      graphics API would not change by the time scene graph is initialized.
      
      Waiting for scene graph initialization has also become less relevant since
      0dbfb4b9, where RHI probing and `QQuickWindow::setGraphicsApi()` became
      being used in almost all cases. If we set the graphics API explicitly,
      it means that the same API can be considered by the compositor directly
      without getting concerned by scene graph initialization and it getting end
      up with a different graphics API.
      3dff231e
    • Pierre Lamot's avatar
      qt: fix lua interface extension not loading · a52a78e6
      Pierre Lamot authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      extension_dialog_t is not a registered type in qt so the signal was failing.
      
      It's usually dangerous to pass VLC C object in Qt signals regarding the lifetime
      of these objects, so rather than registering the type, the object is passed
      though lambda capture assumming that the current comment and code is correct.
      a52a78e6
    • Fatih Uzunoğlu's avatar
      qt: properly handle VLC_PLAYER_VOUT_STOPPED · e1560198
      Fatih Uzunoğlu authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      When last vout stops, a dummy vout is created.
      For the interface, this has no relevance and
      "has video" property should be set to false.
      e1560198
    • Tristan Matthews's avatar
      aom: fix row-mt flag · 29c13755
      Tristan Matthews authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      When using var_GetBool, "--sout-aom-row-mt" was a noop.
      29c13755
    • Tristan Matthews's avatar
      dav1d: add dav1d-all-layers flag · 6ffede3f
      Tristan Matthews authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      This will output all spatial layers if requested, defaults to false (the built-in dav1d
      behavior would defaults this to true).
      
      Fix suggested-by Maryla Ustarroz
      
      Fixes #28776
      6ffede3f
    • Fatih Uzunoğlu's avatar
      qt: use `QQuickWindow::effectiveDevicePixelRatio()` in RoundImage · 9fda4301
      Fatih Uzunoğlu authored and Steve Lhomme's avatar Steve Lhomme committed
      9fda4301
Loading