Alexandre Janniaux authored 3 years ago and François Cartegnie committed 3 years ago

The try/catch for exception safety was already needed there, and this
simplify the code a lot, so this moves the allocation into unique_ptr to
benefit from RAII destructors.

In addition, this commit change the call to free(p_sys) into the correct
C++ delete, avoiding a mismatch new/free.

Introduced in 0d89fe3f.

Pierre Ynard authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

A new variant of compound transformation has the Base64 alphabet
generation and the compounding itself as two separate data array
elements, contrary to what was observed so far. Add support for those.

Fixes #26285

Pierre Ynard authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

A new standalone compound transformation, taking its Base64 alphabet
as extra input argument, has revealed itself. We support parsing and
passing this one more argument from the script section.

Technically this last argument can be a function or rather the result
of its call, but with no argument, we know what's always returned, and
don't need to treat it as a function. This is less clean but simpler and
will do for now.

Pierre Ynard authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Newly observed transformations reveal that the uncertain character
code variable used as constant offset, really isn't one and is simply
supposed to be the alphabet's length. Thus even more so, it is a no-op
on the alphabet's algebraic modulo group, and probably just an artifact
of how modulo of negative numbers is handled in javascript. Simplify it
away.

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

fixes #26278
fixup 856f20a2

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Starting iOS 11.0

Setting it to LongFormAudio or LongFormVideo will select audio devices
that are used for long playback (music or video) in priority.

Romain Vimont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This avoids forward static functions declarations.

Romain Vimont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

On error, framebuffers and textures were not destroyed on all code
paths.

Romain Vimont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The plane sizes are specific to a filter.

Romain Vimont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Initialization of framebuffers is related to a single vlc_gl_filter.

Move it to filter.c.

Romain Vimont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The assertion about tex_count == 0 actually checked that
InitFramebuffersOut() has not already been called.

Move it to the function itself for clarity.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

I hate the myself of 2years ago for the lack of explanion on the
original commit. But DTS 14b inside WAV is now played as PCM, using the
same receiver with the same Windows machine than 2 years ago.

Reverting this commit fix it (for 14b and 16b). Maybe a receiver or a
Windows update fixed it ?

This reverts commit 3c68e5ff.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Redirect tar output to /dev/null as we only care about the exit code
here, not what it prints to stdout.

(instead of copying them)

...and prepare for callback structure separation.

This is always non-NULL.

According to RFC 3551 §4.5, those audio encodings have variable
sampling rates.

Some payload type initialisation callbacks will be needing access to a
context soon enough.

The init callback can not be NULL. That would be completely useless.